🐛 Check GitHub RequiredPullRequestReviews before access #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #mondoohq/cnspec#289 Signed-off-by: Christian Zunker <[email protected]>
imilchev
reviewed
Jan 27, 2023
| Users: []string{}, | ||
| Teams: []string{}, | ||
| } | ||
| rprr, err := core.JsonToDict(githubRequiredPullRequestReviews{}) |
There was a problem hiding this comment.
why do you not initialize this as nil? It's making the code shorter and it won't do unnecessary work of serializing stuff.
Suggested change
| rprr, err := core.JsonToDict(githubRequiredPullRequestReviews{}) | |
| var rprr map[string]interface{} |
There was a problem hiding this comment.
Good point. Thanks.
| ghDismissalRestrictions.Users = append(ghDismissalRestrictions.Users, branchProtection.RequiredPullRequestReviews.DismissalRestrictions.Users[i].GetLogin()) | ||
| if branchProtection.RequiredPullRequestReviews.DismissalRestrictions != nil { | ||
| ghDismissalRestrictions = &githubDismissalRestrictions{ | ||
| Users: []string{}, |
There was a problem hiding this comment.
nit: when possible I try to initialize slices with the correct size beforehand. This makes memory allocation a bit more efficient since the underlying array doesn't need to be extended and copied in memory.
Suggested change
| Users: []string{}, | |
| Users: make([]string{}, 0, len(branchProtection.RequiredPullRequestReviews.DismissalRestrictions.Users)), |
This means create a slice with length 0 with an underlying array of size len(branchProtection...)
Signed-off-by: Christian Zunker <[email protected]>
vjeffrey
approved these changes
Jan 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mondoohq/cnspec#289
Signed-off-by: Christian Zunker [email protected]