🧹 Use extra Error type for 'object not found' #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, we can check for specific cases where resources weren't found. Signed-off-by: Christian Zunker <[email protected]>
czunker
force-pushed
the
christian/k8s_custom_not_found_err
branch
from
78ddfb3
to
ada9fc3
Compare
czunker
changed the title
imilchev
reviewed
Oct 24, 2022
resources/packs/k8s/common.go
Outdated
| @@ -15,6 +15,12 @@ import ( | |||
| "k8s.io/apimachinery/pkg/runtime" | |||
| ) | |||
|
|
|||
| type K8sObjectNotFound struct{} | |||
|
|
|||
| func (e *K8sObjectNotFound) Error() string { | |||
There was a problem hiding this comment.
nit: Since we call it "k8s resource" in the log messages, shouldn't the error be called K8sResourceNotFound?
There was a problem hiding this comment.
Good point. Thanks.
resources/packs/k8s/common.go
Outdated
| @@ -241,7 +247,8 @@ func initNamespacedResource[T K8sNamespacedObject]( | |||
| } | |||
| } | |||
|
|
|||
| return args, *new(T), fmt.Errorf("not found") | |||
| // the error K8sObjectNotFound is checked by cnspec | |||
| return args, *new(T), &K8sObjectNotFound{} | |||
There was a problem hiding this comment.
Where will the error be checked? It seems like in runtime.go you are not returning that error type anymore but just error. Is it intentional?
There was a problem hiding this comment.
Signed-off-by: Christian Zunker <[email protected]>
imilchev
approved these changes
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Zunker [email protected]