🧹 Use extra Error type for 'object not found'

This way, we can check for specific cases where resources weren't found.

Signed-off-by: Christian Zunker <[email protected]>

.vscode/launch.json

@@ -34,6 +34,18 @@
         "processes.list"
       ],
     },
+    {
+      "name": "cnquery-run-k8s-pod",
+      "type": "go",
+      "request": "launch",
+      "program": "${workspaceRoot}/apps/cnquery/cnquery.go",
+      "args": [
+        "run",
+        "k8s",
+        "-c",
+        "k8s.pod(name: 'passing-pod-yaml', namespace: 'test-vanish'){ name }"
+      ],
+    },
     {
       "name": "cnquery-run-admission",
       "type": "go",

resources/packs/k8s/common.go

@@ -15,6 +15,12 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 )
 
+type K8sObjectNotFound struct{}
+
+func (e *K8sObjectNotFound) Error() string {
+	return "could not find k8s resource"
+}
+
 func k8sProvider(t providers.Instance) (k8s_provider.KubernetesProvider, error) {
 	at, ok := t.(k8s_provider.KubernetesProvider)
 	if !ok {
@@ -241,7 +247,8 @@ func initNamespacedResource[T K8sNamespacedObject](
 		}
 	}
 
-	return args, *new(T), fmt.Errorf("not found")
+	// the error K8sObjectNotFound is checked by cnspec
+	return args, *new(T), &K8sObjectNotFound{}
 }
 
 func initResource[T K8sObject](
@@ -308,5 +315,5 @@ func initResource[T K8sObject](
 		}
 	}
 
-	return nil, *new(T), fmt.Errorf("not found")
+	return nil, *new(T), &K8sObjectNotFound{}
 }

resources/runtime.go

@@ -189,7 +189,7 @@ func (ctx *Runtime) CreateResourceWithID(name string, id string, args ...interfa
 	// with the `Id` field set to look up an existing resource
 	res, err := r.Factory(ctx, argsMap)
 	if err != nil {
-		return nil, errors.New("failed to create resource '" + name + "': " + err.Error())
+		return nil, fmt.Errorf("failed to create resource '%s': %w", name, err)
 	}
 	if res == nil {
 		return nil, errors.New("resource factory produced a nil result for resource '" + name + "'")