Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix conversion of primitives with NO type #1456

Merged
merged 1 commit into from
Aug 8, 2023
Merged

🐛 Fix conversion of primitives with NO type #1456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llx/data_conversions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,8 @@ func (r *Result) RawData() *RawData {

data := &RawData{}
if r.Data != nil {
if r.Data.IsNil() {
// The type can be empty, when we do not have data
if r.Data.IsNil() || types.Type(r.Data.Type).IsEmpty() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, als r.Data.(Map|Array|Value) are empty. We could also add these as checks.

data.Type = types.Nil
} else {
data = r.Data.RawData()
Expand Down
Loading