🐛 Fix conversion of primitives with NO type #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case we have a resource without data, it also does not have a type. We need to catch this to prevent the error: `cannot convert primitive with NO type information` This happens, e.g., when we test for the exists of a file before doing anything else with the resource. Partially-Fixes #957 Signed-off-by: Christian Zunker <[email protected]>
|
Before: and after in the UI: |
czunker
commented
Aug 7, 2023
| @@ -461,7 +461,8 @@ func (r *Result) RawData() *RawData { | |||
|
|
|||
| data := &RawData{} | |||
| if r.Data != nil { | |||
| if r.Data.IsNil() { | |||
| // The type can be empty, when we do not have data | |||
| if r.Data.IsNil() || types.Type(r.Data.Type).IsEmpty() { | |||
There was a problem hiding this comment.
At this point, als r.Data.(Map|Array|Value) are empty. We could also add these as checks.
|
I used this query as a test: https://github.com/mondoohq/cnspec-policies/blob/main/core/mondoo-linux-security.mql.yaml#L1084 |
jaym
approved these changes
Aug 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we have a resource without data, it also does not have a type. We need to catch this to prevent the error:
cannot convert primitive with NO type informationThis happens, e.g., when we test for the exists of a file before doing anything else with the resource.
Partially-Fixes #957