Unglobalize node page styles #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are certain places where headings are meant to be left aligned, and certain ones where they are meant to be centered. Rather than globally deciding one or the other, they should be wrapped in a component like AppSection that decides how they should be aligned.
Instead, use `width="full"` in all AppSection components rendered by PageNode. Additionally, add special margin handling within PageNode.vue component for adding margins for the table of contents. (Note, this part may be a temporary fix; it may makes more sense to render the Table of contents inline on the page).
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #858 +/- ##
=======================================
Coverage 71.30% 71.30%
=======================================
Files 91 91
Lines 3136 3136
=======================================
Hits 2236 2236
Misses 900 900 ☔ View full report in Codecov by Sentry. |
kevinschaper
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Summary
Removes global style changes done in the process of creating the new node overview page.
Checks