Formatting of Headings broken with new Tables

[amc-corey-cox]

In #775 - we somehow broke the formatting of the headers. I've undeleted the branch issue-734-all-association-sections and added a comment to the PR.

I'm looking into the specific line that causes the problem.

[amc-corey-cox]

The commit where the issue appears to have occurred is: c1dca62

[ptgolden]

The issue is that text-align is being set twice for heading elements that are children of AppSection components. Once in the global CSS settings:

monarch-app/frontend/src/global/styles.scss

Lines 33 to 61 in 2c878e8

	h1 {
	width: 100%;
	margin: 0;
	padding: 10px 0;
	font-weight: 600;
	font-size: 1.5rem;
	letter-spacing: 1px;
	text-align: left;
	/** text-transform: uppercase; */
	}
	h2 {
	width: 100%;
	margin: 0;
	padding: 10px 0;
	font-weight: 500;
	font-size: 1.3rem;
	text-align: left;
	}
	h3 {
	width: 100%;
	margin: 0;
	margin-bottom: -20px;
	padding: 10px 0;
	font-weight: 500;
	font-size: 1.1rem;
	text-align: left;
	}

And then again in the AppSection container:

monarch-app/frontend/src/components/AppSection.vue

Lines 42 to 51 in 2c878e8

	&.center {
	align-items: center;
	gap: 40px;
	text-align: center;
	}
	&.left {
	align-items: flex-start;
	gap: 20px;
	text-align: left;

Because the former's specificity is higher, it is being used. The solution is to take text-align out of the heading elements in the global CSS, because they are not always left aligned.

[ptgolden]

The place where those changes were made is 2c878e8

[ptgolden]

Ooops, specifically 4ae405b. In any case, if headings can be aligned multiple ways, then they their alignment probably shouldn't be defined globally.

[ptgolden]

Fixed in fe08db5

[ptgolden]

In #775 - we somehow broke the formatting of the headers. I've undeleted the branch issue-734-all-association-sections and added a comment to the PR.

Since the PR is merged, it's not possible to add commits to it anymore on the issue-734-all-associations-sections branch. Happy to make a new PR.

[amc-corey-cox]

I think we should make a new PR. - You may want to start from main or merge in main in order to make the PR a little more sane.

[amc-corey-cox]

Oh, it looks like you may have already started from main. When you make the PR, I recommend you add Kevin as the reviewer just so he can see what was going on.