-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port webhooks api to new switch pattern #1404
Closed
Closed
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d864ff0
feat: port webhooks api to new switch pattern
rishtigupta 6de668d
fix: common integ tests
rishtigupta fccafce
fix: update package-lock.json
rishtigupta 0a8b8f9
fix: doc examples
rishtigupta 87c11f5
fix: comment out the failing examples
rishtigupta 3465cad
fix: comment out all webhook examples
rishtigupta cc1e7b4
fix: add commented examples again
rishtigupta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import { | ||
CredentialProvider, | ||
DeleteStoreResponse, | ||
ListStoresResponse, | ||
PreviewStorageClient, | ||
StorageConfigurations, | ||
} from '@gomomento/sdk'; | ||
|
||
async function main() { | ||
const storageClient = new PreviewStorageClient({ | ||
configuration: StorageConfigurations.Laptop.latest(), | ||
credentialProvider: CredentialProvider.fromEnvironmentVariable({ | ||
environmentVariableName: 'MOMENTO_API_KEY', | ||
}), | ||
}); | ||
|
||
// list stores | ||
const listStoresResponse = await storageClient.listStores(); | ||
|
||
switch (listStoresResponse.type) { | ||
case ListStoresResponse.Success: { | ||
const storeNames = listStoresResponse.stores().map(store => store.getName()); | ||
for (const store of storeNames) { | ||
const deleteStoreResponse = await storageClient.deleteStore(store); | ||
if (deleteStoreResponse.type === DeleteStoreResponse.Success) { | ||
console.log(`Deleted store ${store}`); | ||
} else { | ||
console.error(`Error deleting store ${store}: ${deleteStoreResponse.message()}`); | ||
} | ||
} | ||
break; | ||
} | ||
case ListStoresResponse.Error: { | ||
console.error(`Error listing stores: ${listStoresResponse.message()}`); | ||
} | ||
} | ||
} | ||
|
||
main() | ||
.then(() => { | ||
console.log('success!!'); | ||
}) | ||
.catch((e: Error) => { | ||
console.error(`Uncaught exception while running example: ${e.message}`); | ||
throw e; | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to comment out the example code for webhooks since the CI kept failing for it.
Will publish this sdk version and update the tests accordingly in a follow-up pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm confused as to why these would fail, the package.json in the examples dir should be pinned to a released version of the SDK. Also it's important for the sake of backward compatibility that this syntax still work, so I think we will need to get to the bottom of it before we merge this.