feat: port webhooks api to new switch pattern #1404
Conversation
rishtigupta
force-pushed
the
feat/webhook-apis-new-pattern
branch
from
99f5f04 to
d864ff0
Compare
rishtigupta
requested review from
cprice404 and
a team
and removed request for
a team and
cprice404
rishtigupta
force-pushed
the
feat/webhook-apis-new-pattern
branch
from
fdf32ef to
526c381
Compare
rishtigupta
force-pushed
the
feat/webhook-apis-new-pattern
branch
from
526c381 to
fccafce
Compare
rishtigupta
force-pushed
the
feat/webhook-apis-new-pattern
branch
from
679ea20 to
3465cad
Compare
| ); | ||
| } | ||
| } | ||
| // async function example_API_ListWebhooks(topicClient: TopicClient, cacheName: string) { |
There was a problem hiding this comment.
I had to comment out the example code for webhooks since the CI kept failing for it.
Will publish this sdk version and update the tests accordingly in a follow-up pr.
There was a problem hiding this comment.
i'm confused as to why these would fail, the package.json in the examples dir should be pinned to a released version of the SDK. Also it's important for the sake of backward compatibility that this syntax still work, so I think we will need to get to the bottom of it before we merge this.
| @@ -122,6 +122,7 @@ | |||
| "version": "0.9.5", | |||
There was a problem hiding this comment.
why did this file change? just curious
There was a problem hiding this comment.
While I was experimenting with the ci build failures, I reinstalled my node modules
| @@ -98,16 +97,17 @@ export function runWebhookTests( | |||
| webhook.id.cacheName, | |||
| webhook.id.webhookName | |||
| ); | |||
| if (resp instanceof GetWebhookSecret.Success) { | |||
There was a problem hiding this comment.
it would be good to keep at least one test around that uses the old syntax.
Description:
I had to comment out the example code for webhooks since the CI kept failing for it.
Will publish this sdk version and update the tests accordingly in a follow-up pr.
Issue
Closes https://github.com/momentohq/dev-eco-issue-tracker/issues/956