Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation string #943

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

mmaymo
Copy link
Collaborator

@mmaymo mmaymo commented Sep 20, 2024

Handles PIWOO-530

Copy link
Collaborator

@inpsyde-maticluznar inpsyde-maticluznar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmaymo double quotes fix the issue?

@mmaymo
Copy link
Collaborator Author

mmaymo commented Sep 20, 2024

@inpsyde-maticluznar I've tried and it looks like.. I can see the german string.

@inpsyde-maticluznar
Copy link
Collaborator

inpsyde-maticluznar commented Sep 20, 2024

@mmaymo That's a great suggestion. Since WP uses single quotes, I'm not sure how this would resolve the issue. Were you able to reproduce it before switching to double quotes?

Ok, you updated the comment. The great suggestion was to include the QA.

@mmaymo mmaymo merged commit 33f1370 into develop Sep 25, 2024
7 checks passed
@mmaymo mmaymo deleted the fix/PIWOO-530-missing-german-translation branch September 25, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants