-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails the build when running using Maven 3.9.0 #168
Comments
can you provide
For me:
|
I failed to reproduce with simple project but using the very complicated build of https://github.com/eclipse-platform/eclipse.platform.releng.aggregator and
|
Can you check something like: download original files:
check sha1 sum:
next check in your local repo:
show first bytes of pom:
as you see there is no UTF-8 BOM |
Checked all that and got exactly the same matching output as yours. As I fail to come up with small reproducer feel free to close this one and I'll have toopen new one if/when I manage to do so. |
As we see referenced pom doesn't have a BOM marker ... |
I can't reproduce either... |
@michael-o So does it mean that something in my build end up using old plexus-util is the most likely cause of the issue and I should look at the plugins dependency trees to figure that ? |
This is my current assumption, but not with full certainty. Wipe your local repo and check the plugin's class path. We have seen classes in other areas as well. Once in a while. |
I can reproduce it. I confirm this is a bug in the MXParser of the plexus-utils version shipped with Maven 3.9.0. I'll be working on a patch ASAP. |
Maven 3.9.0 has some issues with one of the dependencies: mojohaus/build-helper-maven-plugin#168 This is hopefully fixed im Maven 3.9.1
@michael-o @slawekjaranowski Do you think you can find the time trying with m2e-core where ther issue happens and the build is not complicated from maven POV ? https://github.com/eclipse-m2e/m2e-core/actions/runs/4302035497/jobs/7500001979 |
The problem is fixed in takari/polyglot-maven#259 / eclipse-tycho/tycho#2176 |
By the way, it would be great if the file encoding of the build-helper-maven-plugin/pom.xml Line 1 in 50e05c0
could still be changed to the standard
It would be great if at least the error message could be improved. Because this was not caused by a UTF-8 BOM, but because MXParser do some checking inf the used InputStream classes and extract the encoding from there, so this file defiantly has no UTF-8 BOM. |
Nothing is wrong in using |
Even though |
Here none. Using ISO-8859-1 is just an ugly Windows habit I have seen over the years. |
Thats why I suggest to simply remove the marker for |
|
In any build where Maven3.9.0 is used failure like the following is seen:
The text was updated successfully, but these errors were encountered: