Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] fix build issue caused by build-helper #1105

Closed
wants to merge 1 commit into from

Conversation

gayanper
Copy link
Contributor

What it does

How to test

Author checklist

@gayanper
Copy link
Contributor Author

@iloveeclipse Not sure if this will happen on jenkins since we might have proxy maven repo. But when I was trying build against central repo with a clean local repository i continuously got

Error:  Plugin org.codehaus.mojo:build-helper-maven-plugin:3.3.0 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.codehaus.mojo:build-helper-maven-plugin:jar:3.3.0: 1 problem was encountered while building the effective model
Error:  [FATAL] Non-parseable POM /home/runner/.m2/repository/org/codehaus/mojo/build-helper-maven-plugin/3.3.0/build-helper-maven-plugin-3.3.0.pom: UTF-8 BOM plus xml decl of ISO-8859-1 is incompatible (position: START_DOCUMENT seen <?xml version="1.0" encoding="ISO-8859-1"... @1:42)  @ line 1, column 42

from batch compiler module. Upgrading to latest version fixed it. Let me know what you think

@iloveeclipse
Copy link
Member

@gayanper : I have zero knowledge about maven. @merks may be?

@merks
Copy link
Contributor

merks commented May 31, 2023

I can't see any harm in using a newer version if that solves some problem. I would be nice to know which file has this problem because it does seem wrong to have a BOM in a file encoded with ISO-8859-1...

@akurtakov
Copy link
Contributor

The whole story is an issue in build-helper-maven-plugin itself (even in underlying xml handling library). If one is interested read mojohaus/build-helper-maven-plugin#168

@gayanper gayanper marked this pull request as ready for review June 5, 2023 17:02
@akurtakov
Copy link
Contributor

This has been fixed via #1392 .

@akurtakov akurtakov closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants