Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v8.1.0 (including event instrumentation) #190

Merged
merged 25 commits into from
Sep 19, 2019
Merged

Release v8.1.0 (including event instrumentation) #190

merged 25 commits into from
Sep 19, 2019

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Sep 17, 2019 •
edited
Loading

Updates for release v8.1.0

  • Bumped version
  • Merged master and resolved conflicts
  • Made test/unit/base.js use a random port as to not conflict with any pre-existing running servers that may have started in the background.
  • Dependency re-factoring:
    • Removed unused dependencies
    • Moved dependencies used for tests to devDependencies
    • Added central-services-logger and updated dependency and tests
    • updated central-services-health to fix vulnerability DoS issue
    • Update tests to support Hapi + Joi 16.x:
      • wrapped payload in Joi.object().
      • changed .valid() to use expanded parameters instead of an array.
  • Add required tags to initial span (transactionId, transactionType, transactionAction, source, destination, payerFsp, payeeFsp)
  • Added getPort to unit tests to generate random port to avoid port conflict when running ml-api (or any other service on port 3000) in the background

Neal Donnan and others added 16 commits August 21, 2019 09:53
Added Hapi custom event module and created event span in notification…
2cb0cd2 
… handler
Implementing event framework
9278e17
Merge branch 'master' into feature/804integrateEventFramework
68e004c 
# Conflicts:
#	package-lock.json
Added state to event finish call on error
1afe634
Merge branch 'master' into feature/804integrateEventFramework
7abcd27
Included published version of central-services-shared and event-dsk
d05258b
Bumped version number
43d1f4d
Fixed transfer prepare integration test
20081aa
Fixed version number
a93a37d
Merge branch 'master' into feature/804integrateEventFramework
a3d0413 
# Conflicts:
#	package-lock.json
Added debug logging for kafka message details
a58dc3d
Updated event sdk to latest snapshot
30fc9c8
Included snapshot version of central services shared for egress kafka…
4638217 
… message logging
Updated to latest event-sdk snapshot
12045f6
@mdebarros
updated event-sdk
fc2845e
@mdebarros
Updates for release/v8.1.0
222946a 
- Merged master and resolved conflicts
- Added central-services-logger and updated dependency and tests
@mdebarros mdebarros self-assigned this Sep 17, 2019
@mdebarros
updated central-services-health to fix vulnerability DoS issue
b8efa7c
@mdebarros
Updated for v8.1.0 release
5817655 
- Update tests to support Hapi  + Joi 16.x:
   - wrapped payload in Joi.object().
   - changed .valid() to use expanded parameters instead of an array.
- Bumped version.
- Made test/unit/base.js use a random port as to not conflict with any pre-existing running servers that may have started in the background.
@mdebarros
Re-factored dependencies
87f8bbb 
- Removed unused dependencies
- Moved dependencies used for tests to devDependencies
@mdebarros mdebarros mentioned this pull request Sep 17, 2019
Closed
rmothilal
rmothilal previously approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smile approval

@elnyry-sam-k elnyry-sam-k mentioned this pull request Sep 19, 2019
Closed
55 tasks
@mdebarros mdebarros requested a review from rmothilal September 19, 2019 13:51
rmothilal
rmothilal previously approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up

vgenev
vgenev previously approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@vgenev vgenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

ndonnan
ndonnan previously approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@ndonnan ndonnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mdebarros mdebarros dismissed stale reviews from ndonnan, vgenev, and rmothilal via 5e6261f September 19, 2019 15:36
@mdebarros mdebarros requested a review from ndonnan September 19, 2019 15:37
ndonnan
ndonnan approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@ndonnan ndonnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mdebarros mdebarros merged commit e387cec into master Sep 19, 2019
This was referenced Oct 16, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndonnan ndonnan ndonnan approved these changes

@rmothilal rmothilal rmothilal left review comments

@vgenev vgenev vgenev left review comments

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@gibaros gibaros Awaiting requested review from gibaros

@oderayi oderayi Awaiting requested review from oderayi

Assignees

@mdebarros mdebarros

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mdebarros @ndonnan @vgenev @rmothilal @oderayi