Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Framework - Integrate into ML-API-Adapter #804

Closed
40 of 55 tasks
mdebarros opened this issue Jun 10, 2019 · 2 comments
Closed
40 of 55 tasks

Event Framework - Integrate into ML-API-Adapter #804

mdebarros opened this issue Jun 10, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@mdebarros
Copy link
Member

mdebarros commented Jun 10, 2019

Goal:

As a Hub Operator I want to integrate Event Framework into Mojaloop components so that so that all events (errors, general, etc) can be audited and traced appropriately for Prepare and Fulfil flows

Tasks:

  • Event Framework
    • Enhance central services shared
      • Create a Hapi plugin with onPreAuth and onPreResponse to create a span per api request
      • Add to the README and jsdoc a description of the 'sampled' route tag for span creation
      • Integrate SDK for logging [ ? ]
        • ml-api-adapter - API
          • Integrate event-sdk
          • Configuration in default.json (e.g. sidecar enabled, logging mode etc) defer
          • Import NPM dependency
          • Make route ids more meaningful for the event i.e. ml_post_transfer, ml_put_transfer, ml_put_transfer_error
          • Add 'sampled' route tags
          • Integrate into health end-points for Event Sidecar (if sidecar is enabled) defer to Event, Auditing and Error Framework Design - Part III - Interlocks #834
          • Test events being Recorded into EFK
          • Logs (replace existing logs)
          • Add Audits for beginning of receiving request for Prepare, Fulfil, Errors, etc
          • Add Errors for both Internal (e.g. technical errors) and External (e.g. callback errors)
          • Traces for main span for Prepare, Fulfil, Errors, etc
          • Helm [ @mdebarros ]
            • Integrate event-sidecar into helm chart
            • Updated configuration for default.json in helm chart
        • ml-api-adapter - Notifications
          • Integrate event-sdk
          • Configuration in default.json (e.g. sidecar enabled, logging mode etc) defer
          • Integrate into health end-points for Event Sidecar (if sidecar is enabled) defer to Event, Auditing and Error Framework Design - Part III - Interlocks #834
          • Test events being Recorded into EFK
          • Logs (replace existing logs)
          • Add Audits for beginning of receiving request for Notifications
          • Add Errors for both Internal (e.g. technical errors - unable to get end-points from Central-Ledger, unable to send callback due to network) and External (e.g. callback resulted in an error from DFSP)
          • Traces for main span for Notifications
          • Helm [ @mdebarros ]
            • Integrate event-sidecar into helm chart
            • Updated configuration for default.json in helm chart
  • Integration Testing (with ML-API-Adapter via side-car)
    • Test Log events (info, debug, error, etc) on EFK
    • Test Audit events on EFK
    • Test Trace events on APM

Acceptance Criteria:

  • Designs are up-to-date
  • Unit Tests pass
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment configs.
  • Event Framework integrated into ML-API-Adapter for Prepare and Fulfil flows
    • Ensure that components cannot operate without Sidecar functioning correctly when enabled
    • Ensure that components will not startup without Sidecar when enabled
    • Sidecar can be disabled for local development and/or debugging purposes only
  • Helm Charts
    • Deployment includes sidecar as part of deployment
    • Deployment includes sidecar configuration
  • Recording of Events are correctly being captured
    • Logs events into EFK
    • Audit events into EFK
    • Trace events into APM (and EFK via APM)

Pull Requests:

Follow-up:

  • N/A

Dependencies:

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@mdebarros mdebarros added this to the Sprint 6.4 milestone Jun 10, 2019
@mdebarros mdebarros changed the title Event SDK - Integrate into Mojaloop Components PoC Event SDK - Integrate into Mojaloop Components Jun 10, 2019
@elnyry-sam-k elnyry-sam-k removed this from the Sprint 6.4 milestone Jun 28, 2019
@mdebarros mdebarros changed the title PoC Event SDK - Integrate into Mojaloop Components PoC Event SDK - Integrate into ML-API-Adapter Jul 2, 2019
@mdebarros mdebarros changed the title PoC Event SDK - Integrate into ML-API-Adapter Event SDK - Integrate into ML-API-Adapter Jul 2, 2019
@mdebarros mdebarros changed the title Event SDK - Integrate into ML-API-Adapter Event Framework - Integrate into ML-API-Adapter Jul 2, 2019
@mdebarros mdebarros added this to the Sprint 7.1 milestone Jul 8, 2019
@elnyry-sam-k elnyry-sam-k removed this from the Sprint 7.1 milestone Jul 18, 2019
@elnyry-sam-k elnyry-sam-k added this to the Sprint 7.3 milestone Aug 12, 2019
@ndonnan ndonnan self-assigned this Aug 13, 2019
@elnyry-sam-k elnyry-sam-k modified the milestones: Sprint 7.3, Sprint 7.4 Aug 17, 2019
@elnyry-sam-k
Copy link
Member

Followed-up by #960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants