feat: fx implementation #412
Conversation
kalinkrustev
requested review from
mdebarros,
elnyry-sam-k,
oderayi and
shashi165
as code owners
|
| @@ -66,26 +66,26 @@ | |||
| "@hapi/boom": "10.0.1", | |||
| "@hapi/catbox-memory": "5.0.1", | |||
| "@hapi/good": "9.0.1", | |||
| "@hapi/hapi": "21.3.2", | |||
| "@hapi/hapi": "21.3.10", | |||
| "@hapi/inert": "7.1.0", | |||
| "@hapi/vision": "7.0.3", | |||
| "@mojaloop/central-ledger": "v17.7.2", | |||
| "@mojaloop/central-services-database": "10.7.0", | |||
| "@mojaloop/central-services-error-handling": "12.0.7", | |||
There was a problem hiding this comment.
I think need to add dependency of @mojaloop/sdk-standard-components required by "@mojaloop/central-services-error-handling
There was a problem hiding this comment.
@vijayg10 any comments here?
|
CI steps failing as well, please review |
@elnyry-sam-k Which issues do you mean? |
What Shashi mentioned above and CI was failing earlier, those.. I wanted to tag it because earlier the PR had an approval and I didn't want to see it merged before those were addressed. |
|
The CI failed due to some bug in how CircleCI updates the checks in GitHub. It seems multiple PRs can interfere with each other when reporting the checks. When I clicked at the failed check, I was redirected to a build related to another PR. Anyway, all is passing now. |
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Changes: