Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove misleading commit and rollback #408

Closed
wants to merge 1 commit into from
Closed

fix: remove misleading commit and rollback #408

wants to merge 1 commit into from

Conversation

kalinkrustev
Copy link

Per Knex docs transactions are automatically committed/rolled back when passing an async function to the knex.transaction function.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@kalinkrustev
Copy link
Author

moved to #412

@kalinkrustev kalinkrustev deleted the fix/transactions branch September 30, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros Awaiting requested review from mdebarros mdebarros is a code owner

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k elnyry-sam-k is a code owner

@oderayi oderayi Awaiting requested review from oderayi oderayi is a code owner

@shashi165 shashi165 Awaiting requested review from shashi165 shashi165 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kalinkrustev