Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Bulk Transfers POC #307

Merged
merged 10 commits into from
Jul 8, 2019
Merged

Conversation

ggrg
Copy link
Member

@ggrg ggrg commented Jul 4, 2019

Coverage report before current PR:

=============================== Coverage summary ===============================
Statements   : 84.03% ( 3352/3989 )
Branches     : 79.86% ( 797/998 )
Functions    : 87.7% ( 442/504 )
Lines        : 83.96% ( 3318/3952 )
================================================================================

1..1209
# tests 1209
# pass  1209

# ok

Resulting coverage report:

=============================== Coverage summary ===============================
Statements   : 100% ( 3229/3229 )
Branches     : 100% ( 805/805 )
Functions    : 100% ( 442/442 )
Lines        : 100% ( 3195/3195 )
================================================================================

1..1228
# tests 1228
# pass  1228

# ok

In addition:

  • mongodb connect successfully stubbed, so that stopping mongodb container is no longer required
  • Timer.sleep defaults changed so that total unit tests coverage run time is reduced by 3 secs
  • .istanbul.yml updated to exclude **/bulk**/** from coverage report

Note:

ggrg and others added 8 commits June 13, 2019 18:59
* Bulk migrations and seeds
* Added bulk seeds
* Init BulkTransferPrepareHandler
* added bulk prepare handler
* Fix issues with individual transfers retrieval from object store
* Fixed hanging unit tests
* Disable sidecar
* Integrate introduced Object Store code to BulkPrepareHandler code
* Add MONGODB.URI config
* License and version info, bulkTransferAssociation
* Updated integration tests run config
mojaloop#289)

* Configs and flow to support bulk-prepare action
* Init BulkProcessingHandler
* Fix unit tests
* Handling data storage models
* Finilize bulkTransfer response retrieval from DB
* WIP #1
* Removed kafkaConf.key
Switched to message.id=UUID for fulfil and get
195 unit tests fail
* Fixed unit tests
* Finilizing BulkPrepareHandler
* Unifying mongo schema definitions
* Fixed integration tests and added new endpointTypes
* Fixed tests and added endpoints
* Fix mongoose unique index issue
* Reverting back topicConf.key setting
* Changes as per PR review comments
* Changes related to ml-api-adapter/pull/116 review
* Configs and flow to support bulk-prepare action
* Init BulkProcessingHandler
* Fix unit tests
* Handling data storage models
* Finilize bulkTransfer response retrieval from DB
* WIP #1
* Removed kafkaConf.key
Switched to message.id=UUID for fulfil and get
195 unit tests fail
* Fixed unit tests
* Finilizing BulkPrepareHandler
* Unifying mongo schema definitions
* Fixed integration tests and added new endpointTypes
* Fixed tests and added endpoints
* Fix mongoose unique index issue
* Reverting back topicConf.key setting
* Changes as per PR review comments
* Changes related to ml-api-adapter/pull/116 review
* Add objStore symlink - to be later replaced by the lib
* Linked to central-object-store
* Implement BulkTransfersByIDPut operation
* BulkFulfilHandler Draft Implementation
* Completed BulkTransferFulfil
* central-object-store 6.4.1-snapshot
* Bugfix when extension is undefined
* Upgraded dependency to newest cetnral-object-store
@ggrg ggrg self-assigned this Jul 4, 2019
@ggrg ggrg changed the base branch from feature/bulkTransfersPoc to master July 4, 2019 18:46
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments.

src/handlers/bulk/fulfil/handler.js Show resolved Hide resolved
src/handlers/bulk/fulfil/handler.js Show resolved Hide resolved
src/handlers/bulk/fulfil/handler.js Show resolved Hide resolved
src/handlers/bulk/prepare/handler.js Show resolved Hide resolved
src/handlers/bulk/prepare/handler.js Show resolved Hide resolved
src/handlers/bulk/prepare/handler.js Show resolved Hide resolved
@ggrg ggrg force-pushed the feature/bulkTransfersPoc branch 2 times, most recently from 2a6b8e9 to 163ad01 Compare July 8, 2019 15:11
@ggrg ggrg force-pushed the feature/bulkTransfersPoc branch from 163ad01 to b55c29e Compare July 8, 2019 15:27
@ggrg ggrg requested a review from mdebarros July 8, 2019 15:52
@ggrg ggrg merged commit 9cd16ac into mojaloop:master Jul 8, 2019
@ggrg ggrg deleted the feature/bulkTransfersPoc branch July 8, 2019 16:04
@ggrg ggrg restored the feature/bulkTransfersPoc branch February 27, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants