Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/747-748 Bulk Processing Handler and existing transfer handlers #289

Conversation

ggrg
Copy link
Member

@ggrg ggrg commented Jun 19, 2019

Story #747 and Story #748

  • Bulk Transfer Prepare golden path end-to-end

src/domain/bulkTransfer/index.js Outdated Show resolved Hide resolved
src/handlers/bulk/prepare/handler.js Outdated Show resolved Hide resolved
src/handlers/bulk/processing/handler.js Show resolved Hide resolved
src/handlers/bulk/processing/handler.js Show resolved Hide resolved
@ggrg
Copy link
Member Author

ggrg commented Jun 19, 2019

Thanks for the review @lewisdaly

Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ggrg ggrg merged commit b84e0e5 into mojaloop:feature/bulkTransfersPoc Jun 20, 2019
@ggrg ggrg deleted the feature/747-748BulkProcessingAndExistingHandlers branch June 20, 2019 19:12
ggrg added a commit that referenced this pull request Jul 8, 2019
* Feature/745 Bulk Prepare Handler Implementation (#286)

* Bulk migrations and seeds
* Added bulk seeds
* Init BulkTransferPrepareHandler
* added bulk prepare handler
* Fix issues with individual transfers retrieval from object store
* Fixed hanging unit tests
* Disable sidecar
* Integrate introduced Object Store code to BulkPrepareHandler code
* Add MONGODB.URI config
* License and version info, bulkTransferAssociation
* Updated integration tests run config

* Feature/747-748 Bulk Processing Handler and existing transfer handlers (#289)

* Configs and flow to support bulk-prepare action
* Init BulkProcessingHandler
* Fix unit tests
* Handling data storage models
* Finilize bulkTransfer response retrieval from DB
* WIP #1
* Removed kafkaConf.key
Switched to message.id=UUID for fulfil and get
195 unit tests fail
* Fixed unit tests
* Finilizing BulkPrepareHandler
* Unifying mongo schema definitions
* Fixed integration tests and added new endpointTypes
* Fixed tests and added endpoints
* Fix mongoose unique index issue
* Reverting back topicConf.key setting
* Changes as per PR review comments
* Changes related to ml-api-adapter/pull/116 review

* Feature/746-748-747 Implement Bulk Transfer Fulfil (#290)

* Configs and flow to support bulk-prepare action
* Init BulkProcessingHandler
* Fix unit tests
* Handling data storage models
* Finilize bulkTransfer response retrieval from DB
* WIP #1
* Removed kafkaConf.key
Switched to message.id=UUID for fulfil and get
195 unit tests fail
* Fixed unit tests
* Finilizing BulkPrepareHandler
* Unifying mongo schema definitions
* Fixed integration tests and added new endpointTypes
* Fixed tests and added endpoints
* Fix mongoose unique index issue
* Reverting back topicConf.key setting
* Changes as per PR review comments
* Changes related to ml-api-adapter/pull/116 review
* Add objStore symlink - to be later replaced by the lib
* Linked to central-object-store
* Implement BulkTransfersByIDPut operation
* BulkFulfilHandler Draft Implementation
* Completed BulkTransferFulfil
* central-object-store 6.4.1-snapshot
* Bugfix when extension is undefined

* Feature/746 748 747 implement bulk transfer fulfil (#296)
* Upgraded dependency to newest cetnral-object-store
* Tune up Time.sleep and tests to improve total execution time
* Initial unit testing and coverage config for BulkTransfersPOC
* Upgrade optional and dev dependencies
* Revert {{id}} to {{transferId}} for normal transfers
* Bump up version as for Sprint 7.1
@ggrg ggrg restored the feature/747-748BulkProcessingAndExistingHandlers branch February 27, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants