-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/747-748 Bulk Processing Handler and existing transfer handlers #289
Merged
ggrg
merged 16 commits into
mojaloop:feature/bulkTransfersPoc
from
ggrg:feature/747-748BulkProcessingAndExistingHandlers
Jun 20, 2019
Merged
Feature/747-748 Bulk Processing Handler and existing transfer handlers #289
ggrg
merged 16 commits into
mojaloop:feature/bulkTransfersPoc
from
ggrg:feature/747-748BulkProcessingAndExistingHandlers
Jun 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to message.id=UUID for fulfil and get 195 unit tests fail
ggrg
requested review from
vgenev,
NicoDuvenage,
elnyry-sam-k,
mdebarros and
rmothilal
June 19, 2019 10:43
This was referenced Jun 19, 2019
lewisdaly
requested changes
Jun 19, 2019
Thanks for the review @lewisdaly |
lewisdaly
approved these changes
Jun 20, 2019
mdebarros
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
ggrg
added a commit
that referenced
this pull request
Jul 8, 2019
* Feature/745 Bulk Prepare Handler Implementation (#286) * Bulk migrations and seeds * Added bulk seeds * Init BulkTransferPrepareHandler * added bulk prepare handler * Fix issues with individual transfers retrieval from object store * Fixed hanging unit tests * Disable sidecar * Integrate introduced Object Store code to BulkPrepareHandler code * Add MONGODB.URI config * License and version info, bulkTransferAssociation * Updated integration tests run config * Feature/747-748 Bulk Processing Handler and existing transfer handlers (#289) * Configs and flow to support bulk-prepare action * Init BulkProcessingHandler * Fix unit tests * Handling data storage models * Finilize bulkTransfer response retrieval from DB * WIP #1 * Removed kafkaConf.key Switched to message.id=UUID for fulfil and get 195 unit tests fail * Fixed unit tests * Finilizing BulkPrepareHandler * Unifying mongo schema definitions * Fixed integration tests and added new endpointTypes * Fixed tests and added endpoints * Fix mongoose unique index issue * Reverting back topicConf.key setting * Changes as per PR review comments * Changes related to ml-api-adapter/pull/116 review * Feature/746-748-747 Implement Bulk Transfer Fulfil (#290) * Configs and flow to support bulk-prepare action * Init BulkProcessingHandler * Fix unit tests * Handling data storage models * Finilize bulkTransfer response retrieval from DB * WIP #1 * Removed kafkaConf.key Switched to message.id=UUID for fulfil and get 195 unit tests fail * Fixed unit tests * Finilizing BulkPrepareHandler * Unifying mongo schema definitions * Fixed integration tests and added new endpointTypes * Fixed tests and added endpoints * Fix mongoose unique index issue * Reverting back topicConf.key setting * Changes as per PR review comments * Changes related to ml-api-adapter/pull/116 review * Add objStore symlink - to be later replaced by the lib * Linked to central-object-store * Implement BulkTransfersByIDPut operation * BulkFulfilHandler Draft Implementation * Completed BulkTransferFulfil * central-object-store 6.4.1-snapshot * Bugfix when extension is undefined * Feature/746 748 747 implement bulk transfer fulfil (#296) * Upgraded dependency to newest cetnral-object-store * Tune up Time.sleep and tests to improve total execution time * Initial unit testing and coverage config for BulkTransfersPOC * Upgrade optional and dev dependencies * Revert {{id}} to {{transferId}} for normal transfers * Bump up version as for Sprint 7.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story #747 and Story #748