Clean last check on trigger update #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borovskyav
suggested changes
Nov 25, 2020
api/controller/trigger_test.go
Outdated
| @@ -80,13 +84,13 @@ func TestSaveTrigger(t *testing.T) { | |||
| So(resp, ShouldResemble, &dto.SaveTriggerResponse{ID: triggerID, Message: "trigger updated"}) | |||
| }) | |||
| Convey("Has last check", func() { | |||
| actualLastCheck := lastCheck | |||
| actualLastCheck := emptyLastCheck | |||
There was a problem hiding this comment.
А разве тест не работал без этой правки? Кажется же и так всё норм, у тебя был lastCheck, ты его почистил, получился emptyLastCheck.
Так же не понял, зачем ты в saveTrigger добавил map[string]bool{"super.metric1": true, "super.metric2": true}.
Кароче, да, мой поинт такой - тест вроде и без правок в самом тесте должен был работать же.
There was a problem hiding this comment.
Поправил тест
litleleprikon
force-pushed
the
feature/593-remove-last-check-on-trigger-change
branch
from
f7a544c
to
9ac4843
Compare
borovskyav
previously approved these changes
Feb 10, 2021
In last check some targets have a records in MetricsToTargetRelation dictionary. This records did not cleaned during trigger update that led checker to use metric names from this dictionary to populate the set of metrics to check. Closes #593
litleleprikon
force-pushed
the
feature/593-remove-last-check-on-trigger-change
branch
from
9ac4843
to
e80fb18
Compare
borovskyav
approved these changes
Feb 10, 2021
litleleprikon
deleted the
feature/593-remove-last-check-on-trigger-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In last check some targets have a records in MetricsToTargetRelation
dictionary. This records did not cleaned during trigger update that led
checker to use metric names from this dictionary to populate the set of
metrics to check.
Closes #593