Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old metrics in last check do not remove on trigger change #593

Closed
litleleprikon opened this issue Nov 13, 2020 · 0 comments · Fixed by #596
Closed

Old metrics in last check do not remove on trigger change #593

litleleprikon opened this issue Nov 13, 2020 · 0 comments · Fixed by #596
Labels

Comments

@litleleprikon
Copy link
Contributor

BUG REPORT

What version of Moira are you using ([binary] --version)?

Master on commit a55b5cb

What did you expect to see?

When I change trigger metrics to target relation in last check should be flushed in intellectual way as it will cause creation of metrics in new trigger check.

What did you see instead?

In last check structure appear metric from last check that in changed trigger should not be present. This will cause wrong trigger check.

litleleprikon added a commit that referenced this issue Nov 25, 2020
In last check some targets have a records in MetricsToTargetRelation
dictionary. This records did not cleaned during trigger update that led
checker to use metric names from this dictionary to populate the set of
metrics to check.

Closes #593
litleleprikon added a commit that referenced this issue Feb 10, 2021
In last check some targets have a records in MetricsToTargetRelation
dictionary. This records did not cleaned during trigger update that led
checker to use metric names from this dictionary to populate the set of
metrics to check.

Closes #593
litleleprikon added a commit that referenced this issue Feb 10, 2021
In last check some targets have a records in MetricsToTargetRelation
dictionary. This records did not cleaned during trigger update that led
checker to use metric names from this dictionary to populate the set of
metrics to check.

Closes #593
litleleprikon added a commit that referenced this issue Feb 10, 2021
In last check some targets have a records in MetricsToTargetRelation
dictionary. This records did not cleaned during trigger update that led
checker to use metric names from this dictionary to populate the set of
metrics to check.

Closes #593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant