[Replicated] release-23.1: demo: remove copy referring to telemetry disabling env var #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING` can still be used to disable telemetry for CRDB. With the core deprecation happening however, we want to streamline how people enable / disable telemetry in their cluster, so the copy to this variable has been removed. It will still function as before, the only difference is that it will not show up in the demo startup message. Epic: CRDB-40209 Fixes: cockroachdb#132688 Release note (general change): COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING is no longer mentioned in the demo command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicated from original PR cockroachdb#134083
Original author: blathers-crl[bot]
Original creation date: 2024-11-01T18:25:14Z
Original reviewers: dhartunian
Original description:
Backport 1/1 commits from cockroachdb#133284 on behalf of @angles-n-daemons.
/cc @cockroachdb/release
demo: remove copy referring to telemetry disabling env var
COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTINGcan still be used to disable telemetry for CRDB. With the core deprecation happening however, we want to streamline how people enable / disable telemetry in their cluster, so the copy to this variable has been removed.It will still function as before, the only difference is that it will not show up in the demo startup message.
Epic: CRDB-40209
Fixes: cockroachdb#132688
Release note (general change):
COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING is no longer mentioned in the demo command.
Release justification: part of the core license policy changes