Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: remove copy referring to telemetry disabling env var #133284

Conversation

angles-n-daemons
Copy link
Contributor

demo: remove copy referring to telemetry disabling env var

COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING can still be used to disable telemetry for CRDB. With the core deprecation happening however, we want to streamline how people enable / disable telemetry in their cluster, so the copy to this variable has been removed.

It will still function as before, the only difference is that it will not show up in the demo startup message.

Epic: CRDB-40209
Fixes: #132688
Release note (general change):
COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING is no longer mentioned in the demo command.

`COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING` can still be used to
disable telemetry for CRDB. With the core deprecation happening however,
we want to streamline how people enable / disable telemetry in their
cluster, so the copy to this variable has been removed.

It will still function as before, the only difference is that it will
not show up in the demo startup message.

Epic: CRDB-40209
Fixes: cockroachdb#132688
Release note (general change):
COCKROACH_SKIP_ENABLING_DIAGNOSTIC_REPORTING is no longer mentioned
in the demo command.
@angles-n-daemons angles-n-daemons requested review from a team as code owners October 23, 2024 18:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@angles-n-daemons angles-n-daemons added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 labels Oct 31, 2024
@angles-n-daemons
Copy link
Contributor Author

bors r+

@craig craig bot merged commit 20886d8 into cockroachdb:master Nov 1, 2024
23 checks passed
Copy link

blathers-crl bot commented Nov 1, 2024

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #132688: branch-release-23.1, branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Copy link

blathers-crl bot commented Nov 1, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-133284 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/134083/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-23.2-133284 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/134085/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.2.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-24.1-133284 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/134087/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 24.1.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-24.2-133284 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/134088/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 24.2.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-24.3-133284 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/134089/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 24.3.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@angles-n-daemons angles-n-daemons deleted the remove-telemetry-opt-out-message-demo branch November 1, 2024 19:29
rmloveland added a commit to cockroachdb/docs that referenced this pull request Nov 5, 2024
Fixes:

- DOC-11646
- DOC-11657
- DOC-11658
- DOC-11659
- DOC-11660
- DOC-11661

Summary:

- Update `cockroach demo` docs to remove the banner output about
  disabling telemetry

- This output was removed in
  cockroachdb/cockroach#133284 and then
  backported
rmloveland added a commit to cockroachdb/docs that referenced this pull request Nov 13, 2024
Fixes:

- DOC-11646
- DOC-11657
- DOC-11658
- DOC-11659
- DOC-11660
- DOC-11661

Summary:

- Update `cockroach demo` docs to remove the banner output about
  disabling telemetry

- This output was removed in
  cockroachdb/cockroach#133284 and then
  backported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1 backport-23.2.x Flags PRs that need to be backported to 23.2. backport-24.1.x Flags PRs that need to be backported to 24.1. backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v24.3.0-alpha.2: cockroach demo output still mentions disabling telemetry
3 participants