Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup,linting): fix issues related to changes in setup and pylint #115

Merged
merged 2 commits into from
Apr 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pymake/utils/download.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ def _request_get(url, verify=True, timeout=1, max_requests=10, verbose=False):
if verbose:
msg = f"open request attempt {idx + 1} of {max_requests}"
print(msg)
req = None
try:
req = requests.get(
url, stream=True, verify=verify, timeout=timeout
Expand All @@ -216,7 +217,8 @@ def _request_get(url, verify=True, timeout=1, max_requests=10, verbose=False):
else:
msg = "Cannot open request from:\n" + f" {url}\n\n"
print(msg)
req.raise_for_status()
if req is not None:
req.raise_for_status()

# successful request
break
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
requires = [
"setuptools>=45",
"wheel",
"setuptools_scm>=6.2",
]
build-backend = "setuptools.build_meta"

Expand Down
3 changes: 2 additions & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@
name = mfpymake
version = attr: pymake.config.__version__
description = pymake is a Python package to compile MODFLOW-based models.
long_description = file: README.md
long_description = file: README.md, LICENSE.md
long_description_content_type = text/markdown
author = Joseph D. Hughes
author_email = [email protected]
maintainer = Joseph D. Hughes
maintainer_email = [email protected]
license = CC0
license_files = LICENSE.md
platform = Windows, Mac OS-X, Linux
keywords = MODFLOW, groundwater, hydrogeology
classifiers =
Expand Down