exporters: containerimage: allow targetName to contain multiple values #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist and loop through it while pushing.
AkihiroSuda
reviewed
Aug 7, 2018
| return nil, tagDone(err) | ||
| targetNames := strings.Split(e.targetName, ",") | ||
| for _, targetName := range targetNames { | ||
| if e.opt.Images != nil { |
There was a problem hiding this comment.
nit: if e.opt.Images != nil { targetNames := ...?
There was a problem hiding this comment.
I was not 100% sure about the semantic of that and therefore I tried to keep the change as small as possible (I effectively just moved the old code in a loop)
AkihiroSuda
approved these changes
Aug 7, 2018
tonistiigi
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow that the "name" option of the container image exporter to accept a comma separated list of target names. The code will then loop through it and tag/push to every given target.
Why
This allows us to have one Solve() call which will result in multiple images being pushed with minimal overhead. The alternative would have been to call Solve() multiple times and rely on the cache to speed things up but that would be far from optimal.