Docker exporter - specify multiple tags during build

[opopops]

Hi,

Is it possible to specify more than one name during docker build like docker cli does:

docker build -t name:tag1 -t name:tag2

[tonistiigi]

It's not available atm but should be easy to add if there is a need.

[FernandoMiguel]

I have the occasional need for this.
Saves me doing tag afterwards.

[hpandeycodeit]

@tonistiigi I would like to work on this request. Where should I be starting with this? any pointers?

[tonistiigi]

The image exporter supports multiple names with a comma separated list, added in #561. @hpandeycodeit You could add the same support to oci exporter (docker and oci variant share the implementation). Split the name into an array like in #561 , and modify https://github.com/moby/buildkit/blob/master/exporter/oci/export.go#L198 to take an array of names instead of a single one.

[thaJeztah]

@tonistiigi wondering; will it be possible to specify multiple targets? (Think I wrote a proposal for that somewhere); ie, tag multiple targets (stages)?

[tonistiigi]

@thaJeztah No, multiple builds for multiple targets. This issue is about tags.

[anthonyraymond]

I'd like that too

[sethpollack]

@tonistiigi What is the correct syntax for this? I tried:

--output type=image,name=username/image:tag1,username/image:tag2

And I get:

error: invalid value username/image:tag2

[AkihiroSuda]

Probably you need to quote the string

[sethpollack]

No that doesn't help, seems like this only works with the old --exporter syntax.

[sethpollack]

I think the issue is that --output uses a csv reader

buildkit/cmd/buildctl/build/output.go

Line 20 in f7cf482

csvReader := csv.NewReader(strings.NewReader(s))

[tonistiigi]

Because of the csv reader you need to quote the values with commas and make sure your shell does not interpret them.

[thaJeztah]

^^ for the CSV, the quotes should be around the names=xx,xx,xx because that's a single "field" in the CSV, so;

--output type=image,"name=username/image:tag1,username/image:tag2"

(possibly with escaping the quote if needed to take the shell into account, as mentioned above)

[jauninb]

@thaJeztah @tonistiigi I am facing the same issue that @sethpollack have.
It works using the deprecated --exporter-opt but not using --output
Do you have a working example ?

[giulioprovasi]

I found out that the right syntax (in master branch) is the following:

--output type=image,name=username/image:tag1,name=username/image:tag2,push=true

[voron]

@giulioprovasi 2'nd name just overrides 1'st name, this is not what we need.

--output type=image,"name=username/image:tag1,username/image:tag2"

as specified by @thaJeztah, works for me as expected. I have to escape quotes as mentioned, my Gitlab-CI script part is following

--output type=image,\"name=$CI_REGISTRY_IMAGE:$CI_COMMIT_SHORT_SHA,$CI_REGISTRY_IMAGE:${IMG_TAG}\",push=true

[cheald]

This doesn't seem to work any longer, using:

--output type=image,name=\"registry.local/project:test,registry.local/project:test2\",push=true

I get "error: parse error on line 1, column 16: bare " in non-quoted-field"

Using:

--output type=image,name="registry.local/project:test,registry.local/project:test2",push=true

I get "error: invalid value registry.local/project:test"

What's the right way to do this now?

[tonistiigi]

Your quotes are in the wrong place. \"name=foo,bar\"

[cmdjulian]

I have the same error and I don't get why.

export OUTPUT=$(printf 'type=image,\"name=%s\",buildinfo-attrs=true,push=%s' "$IMAGES" "$PUSH")
buildctl-daemonless.sh build \
      --progress=plain \
      --frontend="$DOCKER_FRONTEND" \
      --opt "filename=$DOCKERFILE_PATH" \
      --local "context=$DOCKER_CONTEXT" \
      --local "dockerfile=$DOCKERFILE_DIR" \
      --output $OUTPUT \
      $BUILDKIT_ARGS

error: parse error on line 1, column 13: bare " in non-quoted-field

Any ideas?

echo $OUTPUT

# returns
type=image,\"name=registry.gitlab.com/foo:latest,registry.gitlab.com/bar:latest\",buildinfo-attrs=true,push=true

this works:

--output type=image,\"name=$IMAGES\",buildinfo-attrs=true,push=$PUSH

[devmittal02]

@cmdjulian were you able to fix the above issue?

[cmdjulian]

Yes I did:

export OUTPUT='type=image,"name='"$IMAGES"'",buildinfo-attrs=true,push='"$PUSH"

This works