resolver: update to new registryhosts based config

[tonistiigi]

fixes #1394
fixes #1271

@dmcgowan

Signed-off-by: Tonis Tiigi [email protected]

[AkihiroSuda]

LGTM. We should also support specifying CA and client certs, but can be a follow-up PR.

[tonistiigi]

@AkihiroSuda Some updates were needed for CI to pass. PTAL again

[fuweid]

thanks god we have this patch. we are using version 0.6.2 and use http2 to push/pull image if there is no TLSClientConfig. The http2 flow control is killing me which makes the push very slow.

anyway, nice to have this patch!

[tonistiigi]

@fuweid I think this requires more optimization actually. Afaics the issue with the array model is that it doesn't lock to the specific config when other fail. So it keeps retrying the ones that will fail for every request making things like mirrors inefficient.

[akavel]

The commit claiming to fix this issue seems to be included in buildkit 0.7.0+. Can someone help me understand how can I find out which version of docker includes buildkit 0.7.0? I don't seem to see go.mod files in the docker or dockerd repo roots, so I don't really know where to search for that 😞 I also tried docker version and docker info (including with DOCKER_BUILDKIT=1), but don't seem to be able to find out "buildkit" mention in their outputs 😞

[thaJeztah]

@akavel docker uses vndr (https://github.com/LK4D4/vndr) to manage dependencies; you can find the commit that's used in docker builds by looking at the vendor.conf file; the commit for docker 19.03.13 can be found here; https://github.com/moby/moby/blob/v19.03.13/vendor.conf#L29

Docker 19.03 uses BuildKit v0.6.x, but the v20.10.0 release candidates are upgraded to v0.8.x

[akavel]

@thaJeztah thanks!!!! ❤️