fix for reference type issue in ts3 (#994) #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS I can cut a new minor version also if desired |
|
My man! (referencing #994 for further details) |
mweststrate
reviewed
Aug 29, 2018
| @@ -156,6 +156,9 @@ export type Primitives = ModelPrimitive | null | undefined | |||
| export type TAndInterface<T, I> = (Exclude<T, Primitives> & I) | Extract<T, Primitives> | |||
|
|
|||
| export interface IComplexType<C, S, T> extends IType<C, S, T> { | |||
| // fake, only used for tying | |||
mweststrate
approved these changes
Aug 29, 2018
|
typo fixed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes IType sometimes being inferred as IComplexType and improves the typings for postProcessSnapshot/preProcessSnapshot