3.2.4 - TypeScript error on types.reference

[birkir]

I have:

mobx-state-tree: 3.2.4
typescript: 3.0.1

• I think something is not working as it should.
  • I've checked documentation and searched for existing issues
  • I've made sure your project is based on the latest MST version
  • Describe observed behavior

---

This is my case:

import { types } from 'mobx-state-tree';
import Cinemas from './Cinemas';

export const Cinema = types.model('Cinema', {
  id: types.identifier,
  name: types.maybe(types.string),
});

//               Here is a typescript error:   ↓
//                                             ↓
export const CinemaReference = types.reference(Cinema, {
  get(identifier: string) {
    return Cinemas.getOrLoadById(identifier) as typeof Cinema.Type || [];
  },
  set(value: typeof Cinema.Type) {
    return value.id;
  },
});

This is the error I get:

Argument of type 'IModelType<ModelPropertiesDeclarationToProperties<{ id: ISimpleType<string>; name: IComplexType<string | undefined, string | undefined, string | undefined> & OptionalProperty; }>, {}, ModelCreationType<...>, ModelSnapshotType<...>, ModelInstanceType<...>>' is not assignable to parameter of type 'IAnyModelType'.
  Types of property 'views' are incompatible.
    Type '<V extends Object>(fn: (self: ModelInstanceType<ModelPropertiesDeclarationToProperties<{ id: ISimpleType<string>; name: IComplexType<string | undefined, string | undefined, string | undefined> & OptionalProperty; }>, {}, ModelCreationType<...>, ModelSnapshotType<...>>) => V) => IModelType<...>' is not assignable to type '<V extends Object>(fn: (self: any) => V) => IModelType<any, any, ModelCreationType<any>, ModelSnapshotType<any>, any>'.
      Type 'IModelType<ModelPropertiesDeclarationToProperties<{ id: ISimpleType<string>; name: IComplexType<string | undefined, string | undefined, string | undefined> & OptionalProperty; }>, any, ModelCreationType<...>, ModelSnapshotType<...>, any>' is not assignable to type 'IModelType<any, any, ModelCreationType<any>, ModelSnapshotType<any>, any>'.
        Types of property 'preProcessSnapshot' are incompatible.
          Type '<S0 = ModelCreationType<ModelPropertiesDeclarationToProperties<{ id: ISimpleType<string>; name: IComplexType<string | undefined, string | undefined, string | undefined> & OptionalProperty; }>>>(fn: (snapshot: S0) => ModelCreationType<...>) => IModelType<...>' is not assignable to type '<S0 = ModelCreationType<any>>(fn: (snapshot: S0) => ModelCreationType<any>) => IModelType<any, any, S0, ModelSnapshotType<any>, any>'.
            Type 'IModelType<ModelPropertiesDeclarationToProperties<{ id: ISimpleType<string>; name: IComplexType<string | undefined, string | undefined, string | undefined> & OptionalProperty; }>, any, any, ModelSnapshotType<...>, any>' is not assignable to type 'IModelType<any, any, any, ModelSnapshotType<any>, any>'.
              Types of property 'postProcessSnapshot' are incompatible.
                Type '<S1 = ModelCreationType<ModelPropertiesDeclarationToProperties<{ id: ISimpleType<string>; name: IComplexType<string | undefined, string | undefined, string | undefined> & OptionalProperty; }>>>(fn: (snapshot: ModelSnapshotType<...>) => S1) => IModelType<...>' is not assignable to type '<S1 = ModelCreationType<any>>(fn: (snapshot: ModelSnapshotType<any>) => S1) => IModelType<any, any, S1, ModelSnapshotType<any>, any>'.
                  Types of parameters 'fn' and 'fn' are incompatible.
                    Types of parameters 'snapshot' and 'snapshot' are incompatible.
                      Type 'ModelSnapshotType<ModelPropertiesDeclarationToProperties<{ id: ISimpleType<string>; name: IComplexType<string | undefined, string | undefined, string | undefined> & OptionalProperty; }>>' is not assignable to type 'ModelSnapshotType<any>'.

Same goes for simple type.reference(Cinema)

[xaviergonz]

thanks! got a fix ready, will open a PR soon