Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EvidenceKind in sql recovery db #3735

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Nov 21, 2023

Previously AttestationEvidenceOneOf was used in sql recovery db. This
prevented decoding the legacy EPID based fog reports. Now EvidenceKind
is used which allows the decoding of legacy EPID fog reports.

Previously `AttestationEvidenceOneOf` was used in sql recovery db. This
prevented decoding the legacy EPID based fog reports. Now `EvidenceKind`
is used which allows the decoding of legacy EPID fog reports.
@nick-mobilecoin
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Contributor

@eranrund eranrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably start a document (if we haven't already) with notes/things to remember when releasing 6.0. I don't think that right now we have a clear out the reports table as part of our new release deployment playbook.

@nick-mobilecoin
Copy link
Collaborator Author

We should probably start a document (if we haven't already) with notes/things to remember when releasing 6.0. I don't think that right now we have a clear out the reports table as part of our new release deployment playbook.

This PR should eliminate the need to clear out the reports table. I think this instance was a misunderstanding on my part.
However I agree we should find a way to capture gotchas or steps to do. Currently we're a bit fragmented on tracking. Internally we have asana, jira and notion. Many of the previous notion release steps have been brought into asana. I would vote we create these kind of tasks there. At the same time it may not work well for a procedure checklist.

@nick-mobilecoin nick-mobilecoin merged commit ad9d4f2 into main Nov 21, 2023
20 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/fog-report-for-epid branch November 21, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants