Add option to render recording locally using "maestro record --local" #2173
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package maestro.cli.graphics | ||
|
|
||
| import org.jcodec.api.FrameGrab | ||
| import org.jcodec.api.awt.AWTSequenceEncoder | ||
| import org.jcodec.common.io.NIOUtils | ||
| import java.awt.Graphics2D | ||
| import java.io.File | ||
|
|
||
| fun Graphics2D.use(block: (g: Graphics2D) -> Unit) { | ||
| try { | ||
| block(this) | ||
| } finally { | ||
| dispose() | ||
| } | ||
| } | ||
|
|
||
| fun AWTSequenceEncoder.use(block: (encoder: AWTSequenceEncoder) -> Unit) { | ||
| try { | ||
| block(this) | ||
| } finally { | ||
| finish() | ||
| } | ||
| } | ||
|
|
||
| fun useFrameGrab(file: File, block: (grab: FrameGrab) -> Unit) { | ||
| NIOUtils.readableChannel(file).use { channelIn -> | ||
| val grab = FrameGrab.createFrameGrab(channelIn) | ||
| block(grab) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| package maestro.cli.graphics | ||
|
|
||
| import maestro.cli.runner.resultview.AnsiResultView | ||
| import maestro.cli.view.ProgressBar | ||
| import maestro.cli.view.render | ||
| import okio.ByteString.Companion.decodeBase64 | ||
| import org.jcodec.api.PictureWithMetadata | ||
| import org.jcodec.api.awt.AWTSequenceEncoder | ||
| import org.jcodec.common.io.NIOUtils | ||
| import org.jcodec.common.model.Rational | ||
| import org.jcodec.scale.AWTUtil | ||
| import java.awt.image.BufferedImage | ||
| import java.io.File | ||
|
|
||
| interface FrameRenderer { | ||
| fun render( | ||
| outputWidthPx: Int, | ||
| outputHeightPx: Int, | ||
| screen: BufferedImage, | ||
| text: String, | ||
| ): BufferedImage | ||
| } | ||
|
|
||
| class LocalVideoRenderer( | ||
| private val frameRenderer: FrameRenderer, | ||
| private val outputFile: File, | ||
| private val outputFPS: Int, | ||
| private val outputWidthPx: Int, | ||
| private val outputHeightPx: Int, | ||
| ) : VideoRenderer { | ||
|
|
||
| override fun render( | ||
| screenRecording: File, | ||
| textFrames: List<AnsiResultView.Frame>, | ||
| ) { | ||
| System.err.println() | ||
| System.err.println("@|bold Rendering video - This may take some time...|@".render()) | ||
| System.err.println() | ||
| System.err.println(outputFile.absolutePath) | ||
|
|
||
| val uploadProgress = ProgressBar(50) | ||
| NIOUtils.writableFileChannel(outputFile.absolutePath).use { out -> | ||
| AWTSequenceEncoder(out, Rational.R(outputFPS, 1)).use { encoder -> | ||
| useFrameGrab(screenRecording) { grab -> | ||
| val outputDurationSeconds = grab.videoTrack.meta.totalDuration | ||
| val outputFrameCount = (outputDurationSeconds * outputFPS).toInt() | ||
| var curFrame: PictureWithMetadata = grab.nativeFrameWithMetadata!! | ||
| var nextFrame: PictureWithMetadata? = grab.nativeFrameWithMetadata | ||
| (0..outputFrameCount).forEach { frameIndex -> | ||
| val currentTimestampSeconds = frameIndex.toDouble() / outputFPS | ||
|
|
||
| // !! Due to smart cast limitation: https://youtrack.jetbrains.com/issue/KT-7186 | ||
| @Suppress("UNNECESSARY_NOT_NULL_ASSERTION") | ||
| while (nextFrame != null && nextFrame!!.timestamp <= currentTimestampSeconds) { | ||
| curFrame = nextFrame!! | ||
| nextFrame = grab.nativeFrameWithMetadata | ||
| } | ||
|
Comment on lines
+52
to
+57
There was a problem hiding this comment. looks like this bug is fixed in Kotlin 2.0 There was a problem hiding this comment. Ah nice good to know! |
||
|
|
||
| val curImage = AWTUtil.toBufferedImage(curFrame.picture) | ||
| val curTextFrame = textFrames.lastOrNull { frame -> frame.timestamp.div(1000.0) <= currentTimestampSeconds } ?: textFrames.first() | ||
| val curText = curTextFrame.content.decodeBase64()!!.string(Charsets.UTF_8).stripAnsiCodes() | ||
| val outputImage = frameRenderer.render(outputWidthPx, outputHeightPx, curImage, curText) | ||
| encoder.encodeImage(outputImage) | ||
|
|
||
| uploadProgress.set(frameIndex / outputFrameCount.toFloat()) | ||
| } | ||
| } | ||
| } | ||
| } | ||
| System.err.println() | ||
| System.err.println() | ||
| System.err.println("Rendering complete! If you're sharing on Twitter be sure to tag us \uD83D\uDE04 @|bold @mobile__dev|@".render()) | ||
| } | ||
|
|
||
| private fun String.stripAnsiCodes(): String { | ||
| return replace("\\u001B\\[[;\\d]*[mH]".toRegex(), "") | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these the same specs for the video we used to record with remote renderer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remote recorder was 30 fps but I think 25 if sufficient. Same resolution