Add option to render recording locally using "maestro record --local" #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leland-Takamine
force-pushed
the
local-record-rendering
branch
from
80667af to
e344e1b
Compare
amanjeetsingh150
approved these changes
Dec 5, 2024
| outputFile = localOutputFile, | ||
| outputFPS = 25, | ||
| outputWidthPx = 1920, | ||
| outputHeightPx = 1080, |
There was a problem hiding this comment.
Are these the same specs for the video we used to record with remote renderer?
There was a problem hiding this comment.
Remote recorder was 30 fps but I think 25 if sufficient. Same resolution
| import java.awt.image.BufferedImage | ||
| import javax.imageio.ImageIO | ||
|
|
||
| class SkiaFrameRenderer : FrameRenderer { |
There was a problem hiding this comment.
I am thinking about what would be the best way to get this from beta to prod (stable):
- Recommending to use this to everyone who raised a Github issue for the remote renderer
- Announcing this in the contributor's lounge or just the announcement channel to see if it works for everyone.
WDYT?
There was a problem hiding this comment.
Yeah I think we can announce in slack and have folks try it out. Lots of users have asked for this
bartekpacia
reviewed
Dec 5, 2024
Comment on lines
+52
to
+57
| // !! Due to smart cast limitation: https://youtrack.jetbrains.com/issue/KT-7186 | ||
| @Suppress("UNNECESSARY_NOT_NULL_ASSERTION") | ||
| while (nextFrame != null && nextFrame!!.timestamp <= currentTimestampSeconds) { | ||
| curFrame = nextFrame!! | ||
| nextFrame = grab.nativeFrameWithMetadata | ||
| } |
There was a problem hiding this comment.
looks like this bug is fixed in Kotlin 2.0
There was a problem hiding this comment.
Ah nice good to know!
Leland-Takamine
force-pushed
the
local-record-rendering
branch
from
e344e1b to
26b211a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Jetbrain's Skiko to render video locally. Skiko is a Kotlin library that provides bindings to Skia which is the rendering engine for Google Chrome and ChromeOS, Android, Flutter, and others.
Why Skia?
The other alternatives I looked into fell short in one way or another (eg. AWT, JavaFX). Skia checked all the boxes.
Example of locally rendered video:
maestro-recording.mp4