Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensitive field to inputText #2088

Closed

Conversation

Fishbowler
Copy link
Contributor

@Fishbowler Fishbowler commented Oct 12, 2024

Proposed changes

Adds a sensitive flag to the inputText command to keep the data being inputted from being printed to console or logs.

- inputText:
    text: $ecr3ts
    sensitive: true

will output this to the console:

 ║    ✅   Input text *******      

and this to the logs:

12:08:22.605 [ INFO] maestro.cli.runner.MaestroCommandRunner.invoke: Input text ******* RUNNING
12:08:22.606 [ INFO] maestro.cli.runner.MaestroCommandRunner.invoke: Input text ******* metadata CommandMetadata(numberOfRuns=null, evaluatedCommand=MaestroCommand(inputTextCommand=InputTextCommand(text=*******, sensitive=true, label=null, optional=false)), logMessages=[], insight=Insight(message=, level=NONE))
12:08:22.607 [ INFO] maestro.Maestro.inputText: Inputting text: *******
12:08:25.154 [ INFO] maestro.cli.runner.MaestroCommandRunner.invoke: Input text ******* COMPLETED

Todo:

Testing

Added tests. Ran em all. There's a couple of unrelated failures being fixed in #2080

Ran a flow locally using ./maestro and scrutinised the console, as well as the output in ¬/.maestro/tests

Issues fixed

Fixes #1226

@Fishbowler
Copy link
Contributor Author

#1944 does this better

@Fishbowler Fishbowler closed this Oct 15, 2024
@Fishbowler Fishbowler deleted the add_sensitive_text branch December 14, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputText: add a way to obscure sensitive text
1 participant