Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add e2e tests for optional #2080

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amanjeetsingh150
Copy link
Collaborator

@amanjeetsingh150 amanjeetsingh150 commented Oct 8, 2024

There were 2 issues with optional commands, this PR creates tests for the issues:

  1. The optional flag on the selector was removed that broke deserialization and the change was not backward compatible. The optional flag on the selector was removed from the test itself which prevented catching this regression. After observing this issue, the optional flag from selector is now deprecated.

  2. Optional flags now throw command skipped exception. This was handled for the commands present in main flow but was missing in composite commands like runFlow. The addition to subFlow is suppose to catch those problem.

@Fishbowler Fishbowler force-pushed the update-e2e-test-optional branch from 4c4c640 to 8863ee6 Compare October 25, 2024 08:50
@Fishbowler
Copy link
Contributor

Rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants