MRG+1: better title in plot_compare_evokeds (closes #6165) #6173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6173 +/- ##
==========================================
+ Coverage 89.01% 89.01% +<.01%
==========================================
Files 410 410
Lines 73883 73885 +2
Branches 12255 12256 +1
==========================================
+ Hits 65765 65767 +2
+ Misses 5223 5222 -1
- Partials 2895 2896 +1 |
drammock
changed the title
agramfort
approved these changes
Apr 22, 2019
agramfort
changed the title
mne/viz/evoked.py
Outdated
| @@ -1875,6 +1875,9 @@ def plot_compare_evokeds(evokeds, picks=None, gfp=False, colors=None, | |||
| _validate_type(vlines, (list, tuple), "vlines", "list or tuple") | |||
|
|
|||
| picks = [] if picks is None else picks | |||
| picked_a_type = isinstance(picks, str) and picks in _DATA_CH_TYPES_SPLIT | |||
| if title is None and picked_a_type: | |||
There was a problem hiding this comment.
Why is the type check necessary? It's only gonna be in _DATA_CH_TYPES_SPLIT if it's a str anyways, and if it's not a str, it'll simply return false right?
And then you can drop 1878 and just have:
if title is None and picks in _DATA_CH_TYPES_SPLIT:
|
Otherwise I'm happy .. |
massich
pushed a commit
to massich/mne-python
that referenced
this pull request
Apr 23, 2019
…ne-tools#6173) * better title in plot_compare_evokeds (closes mne-tools#6165) * use logger.info instead of warn * fix stupidity * simplify
jeythekey
pushed a commit
to jeythekey/mne-python
that referenced
this pull request
Apr 27, 2019
…ne-tools#6173) * better title in plot_compare_evokeds (closes mne-tools#6165) * use logger.info instead of warn * fix stupidity * simplify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
logger.infoinstead ofwarnwhen truncating long titlesmne.viz.plot_compare_evokeds(..., picks='grad')(or anypicksthat is a single channel type), sets title to the channel type instead of listing out (and truncating) channel names.