Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: better automatic plot titles in plot_compare_evokeds #6165

Closed
drammock opened this issue Apr 17, 2019 · 2 comments
Closed

ENH: better automatic plot titles in plot_compare_evokeds #6165

drammock opened this issue Apr 17, 2019 · 2 comments
Assignees

Comments

@drammock
Copy link
Member

plot_compare_evokeds(list_of_evokeds, picks='grad')

yields
RuntimeWarning: More than 6 channels, truncating title ...

Two suggested enhancements:

  1. if picks is one of the standard types (eeg, mag, grad...) then the title should reflect the channel type, rather than trying to list all channel names
  2. if specific channels are requested, the truncation should happen with an info message printed to the terminal, not a RuntimeWarning (admittedly subjective, but I think a warning seems too strong for a "we truncated your plot title" message)
@drammock drammock changed the title remove RuntimeWarning in plot_compare_evokeds? ENH: better automatic plot titles in plot_compare_evokeds Apr 17, 2019
@drammock
Copy link
Member Author

I can take this on at the sprint; cc @jona-sassenhagen because of possible interaction with #4746

@jona-sassenhagen
Copy link
Contributor

Agreed!

I think it's fairly independent and I agree with your judgements though. But we will talk about all this at the sprint anyways.

drammock added a commit to drammock/mne-python that referenced this issue Apr 22, 2019
massich pushed a commit to massich/mne-python that referenced this issue Apr 23, 2019
…ne-tools#6173)

* better title in plot_compare_evokeds (closes mne-tools#6165)

* use logger.info instead of warn

* fix stupidity

* simplify
jeythekey pushed a commit to jeythekey/mne-python that referenced this issue Apr 27, 2019
…ne-tools#6173)

* better title in plot_compare_evokeds (closes mne-tools#6165)

* use logger.info instead of warn

* fix stupidity

* simplify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants