Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website #12885

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Website #12885

merged 4 commits into from
Oct 8, 2024

Conversation

drammock
Copy link
Member

@drammock drammock commented Oct 4, 2024

This PR implements 2 changes to the website's default color palette, following suggestions in #12568 (comment):

  1. swaps the "primary" (teal) and "info" (blue) colors
  2. changes the "secondary" (purple) color to be the "warning" color (orange). Thus if this PR is merged, purple is no longer used in the MNE site (as @cbrnr suggested/requested).

Marking as draft because I'm not actually convinced that this is an improvement:

  • PRO: I think the info boxes look great when they're teal
  • PRO: I think table row hover looks fine / slightly better as orange rather than purple
  • CON: The primary color is mostly used for links, and I think the new blue color looks good in light mode but a bit off in dark mode.
  • CON: The secondary colormostly shows up in link hover effects, and I think the new orange color is a bit too prominent / high contrast for something that flickers on and off as you mouse / scroll through the page.

None of these are show-stoppers for me, so if others strongly prefer how it looks in this PR, we can go for it.

closes #12568

@cbrnr
Copy link
Contributor

cbrnr commented Oct 7, 2024

I like the new colors better than the previous ones. IMO the blue color looks good in both light and dark modes, and I don't think the hover effect is too strong either. So 👍 for these changes.

Regarding the link colors on hover, I noticed that only the underline changes color when hovering over a linked function name (the text stays blue in this case). Maybe you just missed something here?

Also, and this is only marginally related, but didn't we decide sometime ago that our social icons should not use color? I can't find the relevant discussion/decision, but e.g. these screenshots show that the icons used to be gray at some point.

@drammock
Copy link
Member Author

drammock commented Oct 7, 2024

I like the new colors better than the previous ones. IMO the blue color looks good in both light and dark modes, and I don't think the hover effect is too strong either. So 👍 for these changes.

great!

Regarding the link colors on hover, I noticed that only the underline changes color when hovering over a linked function name (the text stays blue in this case). Maybe you just missed something here?

That's a theme default (see, e.g., hovering on function names at https://scikit-learn.org/stable/api/index.html). Not sure if it's intentional or not, I've opened pydata/pydata-sphinx-theme#2006 and pydata/pydata-sphinx-theme#2007.

Also, and this is only marginally related, but didn't we decide sometime ago that our social icons should not use color? I can't find the relevant discussion/decision, but e.g. these screenshots show that the icons used to be gray at some point.

In #12285 (comment), past @cbrnr said:

Either way is fine with me, although I have a slight preference for using color.

So I made them all properly colored in #12301

@drammock
Copy link
Member Author

drammock commented Oct 7, 2024

@larsoner are you OK with these stylistic website changes? You can see most of the result on the computation times page (link hover color, table hover BG highlight color); and you can see the teal info/note admonitions on this page.

Once pydata/pydata-sphinx-theme#2007 lands we should maybe consider going back to using the dev version of the theme for building our site? The theme is much more stable these days than it used to be...

@larsoner
Copy link
Member

larsoner commented Oct 8, 2024

Yes looks good to me and happy to switch to dev, it's easy enough to switch back if it breaks again

@drammock drammock marked this pull request as ready for review October 8, 2024 14:43
@larsoner larsoner enabled auto-merge (squash) October 8, 2024 14:55
@larsoner larsoner merged commit 53f258d into mne-tools:main Oct 8, 2024
28 checks passed
@drammock drammock deleted the website branch October 25, 2024 14:42
larsoner added a commit to larsoner/mne-python that referenced this pull request Oct 28, 2024
* upstream/main: (824 commits)
  Add `psd_args` to `plot_ica_sources` and `ICA.plot_sources` (mne-tools#12912)
  Fix GDF NumPy >= 2 (mne-tools#12909)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12908)
  ENH: Improve report usability (mne-tools#12901)
  MAINT: Avoid problematic PySide6 (mne-tools#12902)
  Sync README dependencies with pyproject.toml (mne-tools#12890)
  remove trailing slash from pybv base URL [ci skip] (mne-tools#12892)
  Cast tuple of filenames to list to improve error handling (mne-tools#12891)
  Website (mne-tools#12885)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12888)
  BUG: Fix bugs with coreg (mne-tools#12884)
  Bump mamba-org/setup-micromamba from 1 to 2 in the actions group (mne-tools#12887)
  Update spacing for comments in pyproject.toml (mne-tools#12886)
  make HTML repr for Forward match others (mne-tools#12883)
  MAINT: Linkchecks [circle deploy] (mne-tools#12882)
  Update roadmap (mne-tools#12872)
  [MRG] Require good and bad channels when creating a SpectrumArray object (mne-tools#12877)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12879)
  MAINT: Update code credit (mne-tools#12880)
  BUG: Fix bug with Path casting (mne-tools#12878)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize website color palette
3 participants