Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix bugs with coreg #12884

Merged
merged 6 commits into from
Oct 7, 2024
Merged

BUG: Fix bugs with coreg #12884

merged 6 commits into from
Oct 7, 2024

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Oct 4, 2024

Found a few bugs when using mne coreg:

  1. Clicking "save trans" would segfault because a Qt widget expected a path str not pathlib.Path, within-release change so no changelog for that
  2. MEG sensors were always shown if present

@larsoner larsoner enabled auto-merge (squash) October 7, 2024 13:23
* upstream/main:
  Update spacing for comments in pyproject.toml (mne-tools#12886)
@larsoner larsoner disabled auto-merge October 7, 2024 15:28
@larsoner larsoner merged commit bddaad9 into mne-tools:main Oct 7, 2024
26 of 28 checks passed
@larsoner larsoner deleted the coreg branch October 7, 2024 15:28
larsoner added a commit to larsoner/mne-python that referenced this pull request Oct 28, 2024
* upstream/main: (824 commits)
  Add `psd_args` to `plot_ica_sources` and `ICA.plot_sources` (mne-tools#12912)
  Fix GDF NumPy >= 2 (mne-tools#12909)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12908)
  ENH: Improve report usability (mne-tools#12901)
  MAINT: Avoid problematic PySide6 (mne-tools#12902)
  Sync README dependencies with pyproject.toml (mne-tools#12890)
  remove trailing slash from pybv base URL [ci skip] (mne-tools#12892)
  Cast tuple of filenames to list to improve error handling (mne-tools#12891)
  Website (mne-tools#12885)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12888)
  BUG: Fix bugs with coreg (mne-tools#12884)
  Bump mamba-org/setup-micromamba from 1 to 2 in the actions group (mne-tools#12887)
  Update spacing for comments in pyproject.toml (mne-tools#12886)
  make HTML repr for Forward match others (mne-tools#12883)
  MAINT: Linkchecks [circle deploy] (mne-tools#12882)
  Update roadmap (mne-tools#12872)
  [MRG] Require good and bad channels when creating a SpectrumArray object (mne-tools#12877)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12879)
  MAINT: Update code credit (mne-tools#12880)
  BUG: Fix bug with Path casting (mne-tools#12878)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants