Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Update windows runner for min version #898

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

gabrielbmotta
Copy link
Collaborator

Due to the deprecation of the windows-2016 runner, all runs that used windows-2016 have been made to use windows-2019 instead.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #898 (101d842) into main (bd31738) will increase coverage by 5.95%.
The diff coverage is 0.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
+ Coverage   30.20%   36.15%   +5.95%     
==========================================
  Files         452      199     -253     
  Lines       39208    11817   -27391     
==========================================
- Hits        11841     4273    -7568     
+ Misses      27367     7544   -19823     
Impacted Files Coverage Δ
libraries/disp/viewers/helpers/scalecontrol.h 0.00% <ø> (ø)
libraries/inverse/hpiFit/hpifit.h 0.00% <ø> (-60.00%) ⬇️
libraries/inverse/hpiFit/hpimodelparameters.h 0.00% <0.00%> (ø)
libraries/inverse/hpiFit/sensorset.h 0.00% <0.00%> (ø)
libraries/inverse/hpiFit/signalmodel.h 0.00% <0.00%> (ø)
libraries/rtprocessing/rthpis.cpp 1.78% <0.00%> (-0.07%) ⬇️
libraries/rtprocessing/rthpis.h 0.00% <ø> (ø)
libraries/utils/file.cpp 0.00% <ø> (ø)
libraries/utils/ioutils.cpp 23.68% <0.00%> (-6.32%) ⬇️
libraries/utils/kmeans.cpp 0.27% <ø> (ø)
... and 295 more

@gabrielbmotta
Copy link
Collaborator Author

I've updated the branch protection rules to reflect the new win version.

@juangpc
Copy link
Collaborator

juangpc commented Sep 6, 2022

Good!

@juangpc juangpc merged commit e40b689 into mne-tools:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants