Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Update windows runner for min version #898

Merged
merged 3 commits into from
Sep 6, 2022
Merged

[MAINT] Update windows runner for min version #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7e2414
Replace deprecated 'windows-2016' with 'windows-2019'
gabrielbmotta Aug 31, 2022
c9d6c19
Change visual studio version
gabrielbmotta Aug 31, 2022
101d842
MAINT: Update call to compiler in windows-2019 min build
gabrielbmotta Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/pullrequest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
max-parallel: 3
matrix:
qt: [5.10.1]
os: [ubuntu-18.04, macos-latest, windows-2016]
os: [ubuntu-18.04, macos-latest, windows-2019]

steps:
- name: Clone repository
Expand All @@ -35,25 +35,25 @@ jobs:
version: ${{ matrix.qt }}
modules: qtcharts
- name: Install Qt (Windows)
if: matrix.os == 'windows-2016'
if: matrix.os == 'windows-2019'
uses: jurplel/install-qt-action@v2
with:
version: ${{ matrix.qt }}
arch: win64_msvc2017_64
modules: qtcharts
- name: Install jom (Windows)
if: matrix.os == 'windows-2016'
if: matrix.os == 'windows-2019'
run: |
Invoke-WebRequest https://www.dropbox.com/s/gbf8sdx8wqxcrnd/jom.zip?dl=1 -OutFile .\jom.zip
expand-archive -path "jom.zip"
echo "D:\a\mne-cpp\mne-cpp\jom" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
- name: Compile BrainFlow submodule (Windows)
if: matrix.os == 'windows-2016'
if: matrix.os == 'windows-2019'
run: |
cd applications\mne_scan\plugins\brainflowboard\brainflow
mkdir build
cd build
cmake -G "Visual Studio 15 2017" -A x64 -DMSVC_RUNTIME=dynamic -DCMAKE_SYSTEM_VERSION=8.1 -DCMAKE_INSTALL_PREFIX="$env:GITHUB_WORKSPACE\applications\mne_scan\plugins\brainflowboard\brainflow\installed" ..
cmake -G "Visual Studio 16 2019" -A x64 -DMSVC_RUNTIME=dynamic -DCMAKE_SYSTEM_VERSION=8.1 -DCMAKE_INSTALL_PREFIX="$env:GITHUB_WORKSPACE\applications\mne_scan\plugins\brainflowboard\brainflow\installed" ..
cmake --build . --target install --config Release
- name: Compile BrainFlow submodule (Linux|MacOS)
if: (matrix.os == 'ubuntu-18.04') || (matrix.os == 'macos-latest')
Expand All @@ -65,12 +65,12 @@ jobs:
make
make install
- name: Compile LSL submodule (Windows)
if: matrix.os == 'windows-2016'
if: matrix.os == 'windows-2019'
run: |
cd applications\mne_scan\plugins\lsladapter\liblsl
mkdir build
cd build
cmake .. -G "Visual Studio 15 2017" -A x64
cmake .. -G "Visual Studio 16 2019" -A x64
cmake --build . --config Release --target install
- name: Compile LSL submodule (Linux|MacOS)
if: (matrix.os == 'ubuntu-18.04') || (matrix.os == 'macos-latest')
Expand All @@ -87,10 +87,10 @@ jobs:
qmake -r MNECPP_CONFIG+=noTests MNECPP_CONFIG+=withBrainFlow MNECPP_CONFIG+=withLsl MNECPP_CONFIG+=withAppBundles
make -j4
- name: Configure and compile MNE-CPP (Windows)
if: matrix.os == 'windows-2016'
if: matrix.os == 'windows-2019'
run: |
# Setup VS compiler
cmd.exe /c "call `"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\vcvars64.bat`" && set > %temp%\vcvars.txt"
cmd.exe /c "call `"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvars64.bat`" && set > %temp%\vcvars.txt"
Get-Content "$env:temp\vcvars.txt" | Foreach-Object { if ($_ -match "^(.*?)=(.*)$") { Set-Content "env:\$($matches[1])" $matches[2] } }
qmake -r MNECPP_CONFIG+=noTests MNECPP_CONFIG+=withBrainFlow MNECPP_CONFIG+=withLsl
jom -j4
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/testci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
max-parallel: 3
matrix:
qt: [5.10.1]
os: [ubuntu-18.04, macos-latest, windows-2016]
os: [ubuntu-18.04, macos-latest, windows-2019]

steps:
- name: Clone repository
Expand All @@ -35,25 +35,25 @@ jobs:
version: ${{ matrix.qt }}
modules: qtcharts
- name: Install Qt (Windows)
if: matrix.os == 'windows-2016'
if: matrix.os == 'windows-2019'
uses: jurplel/install-qt-action@v2
with:
version: ${{ matrix.qt }}
arch: win64_msvc2017_64
modules: qtcharts
- name: Install jom (Windows)
if: matrix.os == 'windows-2016'
if: matrix.os == 'windows-2019'
run: |
Invoke-WebRequest https://www.dropbox.com/s/gbf8sdx8wqxcrnd/jom.zip?dl=1 -OutFile .\jom.zip
expand-archive -path "jom.zip"
echo "D:\a\mne-cpp\mne-cpp\jom" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
- name: Compile BrainFlow submodule (Windows)
if: matrix.os == 'windows-2016'
if: matrix.os == 'windows-2019'
run: |
cd applications\mne_scan\plugins\brainflowboard\brainflow
mkdir build
cd build
cmake -G "Visual Studio 15 2017" -A x64 -DMSVC_RUNTIME=dynamic -DCMAKE_SYSTEM_VERSION=8.1 -DCMAKE_INSTALL_PREFIX="$env:GITHUB_WORKSPACE\applications\mne_scan\plugins\brainflowboard\brainflow\installed" ..
cmake -G "Visual Studio 16 2019" -A x64 -DMSVC_RUNTIME=dynamic -DCMAKE_SYSTEM_VERSION=8.1 -DCMAKE_INSTALL_PREFIX="$env:GITHUB_WORKSPACE\applications\mne_scan\plugins\brainflowboard\brainflow\installed" ..
cmake --build . --target install --config Release
- name: Compile BrainFlow submodule (Linux|MacOS)
if: (matrix.os == 'ubuntu-18.04') || (matrix.os == 'macos-latest')
Expand All @@ -65,12 +65,12 @@ jobs:
make
make install
- name: Compile LSL submodule (Windows)
if: matrix.os == 'windows-2016'
if: matrix.os == 'windows-2019'
run: |
cd applications\mne_scan\plugins\lsladapter\liblsl
mkdir build
cd build
cmake .. -G "Visual Studio 15 2017" -A x64
cmake .. -G "Visual Studio 16 2019" -A x64
cmake --build . --config Release --target install
- name: Compile LSL submodule (Linux|MacOS)
if: (matrix.os == 'ubuntu-18.04') || (matrix.os == 'macos-latest')
Expand All @@ -87,7 +87,7 @@ jobs:
qmake -r MNECPP_CONFIG+=noTests MNECPP_CONFIG+=withBrainFlow MNECPP_CONFIG+=withLsl MNECPP_CONFIG+=withAppBundles
make -j4
- name: Configure and compile MNE-CPP (Windows)
if: matrix.os == 'windows-2016'
if: matrix.os == 'windows-2019'
run: |
# Setup VS compiler
cmd.exe /c "call `"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\vcvars64.bat`" && set > %temp%\vcvars.txt"
Expand Down