Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's create a new problem! #24

Closed
wants to merge 6 commits into from
Closed

Let's create a new problem! #24

wants to merge 6 commits into from

Conversation

szepeviktor
Copy link
Contributor

☣️ Not a PR.

@mlocati
Copy link
Owner

mlocati commented Oct 29, 2023

Yep, pretty useless ATM, since we don't have any dependency yet 😉

@szepeviktor
Copy link
Contributor Author

No problems 😢 😢 😭

But I could investigate why PHP setup takes 2+ minutes.

image

@szepeviktor
Copy link
Contributor Author

It should take 7 seconds!

image

@mlocati
Copy link
Owner

mlocati commented Oct 29, 2023

Is maybe setup-php taking a lot of time when it installs php-cs-fixer?

@szepeviktor
Copy link
Contributor Author

it installs php-cs-fixer?

Yes, I'm opening an issue ...

@szepeviktor
Copy link
Contributor Author

shivammathur/setup-php#773 👀

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Oct 29, 2023 •
edited
Loading

Michele broke the Internet again 🙃

In my laboratory installing php-cs-fixer takes ~1 second.
https://github.com/szepeviktor/byte-level-care/actions/runs/6684954105/job/18162746337?pr=79#step:2:15

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Oct 29, 2023 •
edited
Loading

With the above commit it is 7 seconds!

Investigating ... 🔎

@szepeviktor
Copy link
Contributor Author

It is the PHP setup action! Its latest version has a problem.

@szepeviktor
Copy link
Contributor Author

It run in 2 minutes in my repo too.
https://github.com/szepeviktor/byte-level-care/pull/79/files
Viktor is very conservative with software. I let the messes find bugs. Then I upgrade.

@szepeviktor szepeviktor deleted the patch-1 branch October 29, 2023 18:20
@szepeviktor szepeviktor mentioned this pull request Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szepeviktor @mlocati