Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action takes 7 minutes to run #773

Closed
2 of 5 tasks
szepeviktor opened this issue Oct 29, 2023 · 5 comments
Closed
2 of 5 tasks

Action takes 7 minutes to run #773

szepeviktor opened this issue Oct 29, 2023 · 5 comments
Assignees
@shivammathur
Labels
bug Something isn't working

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Oct 29, 2023 •
edited
Loading

Describe the bug

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems
ubuntu-latest

PHP versions
8.1

To Reproduce
https://github.com/mlocati/unipoints/blob/22602389f51f93b8e53721e6434f1262284c4cad/.github/workflows/tests.yml#L19-L35

Expected behavior
Finish under 10 seconds

Screenshots/Logs
https://github.com/mlocati/unipoints/actions/runs/6684760233/job/18162351050

Additional context
PHIVE could download it as 1 file.
@szepeviktor szepeviktor added the bug Something isn't working label Oct 29, 2023
@szepeviktor szepeviktor mentioned this issue Oct 29, 2023
Closed
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Oct 29, 2023 •
edited
Loading

⚠️ Not with version 2.25.5

2.25.5...2.26.0

I suspect the new Node.JS version.

@shivammathur
Copy link
Owner

shivammathur commented Oct 29, 2023 •
edited
Loading

@szepeviktor

Thanks for reporting this.

Yes, this is not related to php-cs-fixer, but the node process in v20 seems to get stuck after the script has run.

@shivammathur
Copy link
Owner

Fixed in 9855c76

@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Oct 29, 2023
@szepeviktor
Copy link
Contributor Author

Thank you.

@szepeviktor szepeviktor mentioned this issue Oct 29, 2023
Closed
@padupe padupe mentioned this issue Nov 1, 2023
Closed
5 tasks
@shivammathur
Copy link
Owner

Released the fix in https://github.com/shivammathur/setup-php/releases/tag/2.27.0

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Nov 1, 2023
@shivammathur shivammathur changed the title tools: php-cs-fixer:v3 takes 7 minutes to build Action takes 7 minutes to run Nov 1, 2023
@mlocati mlocati mentioned this issue Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivammathur shivammathur

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szepeviktor @shivammathur