Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI fail if have a difference #17

Closed
wants to merge 1 commit into from
Closed

Make CI fail if have a difference #17

wants to merge 1 commit into from

Conversation

szepeviktor
Copy link
Contributor

Nothing should change.

@mlocati
Copy link
Owner

mlocati commented Oct 29, 2023

In my mind, when a new Unicode version is published, I'd adopt this process:

  • Update the value DEFAULT_VERSION in bin/unipoints
  • create a pull request
  • when the pull request gets merged, the GitHub Action
    • will re-create the enums
    • will see that there are differences
    • will push back to main the changes

So, developers won't have to manually run bin/unipoints build: everything will be automatic.

PS: that's what I meant with #4

@mlocati mlocati closed this Oct 29, 2023
@szepeviktor szepeviktor deleted the patch-1 branch October 29, 2023 10:50
@mlocati
Copy link
Owner

mlocati commented Oct 29, 2023

@szepeviktor Here's what I meant: #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants