Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push changed built assets #21

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Push changed built assets #21

merged 1 commit into from
Oct 29, 2023

Conversation

mlocati
Copy link
Owner

@mlocati mlocati commented Oct 29, 2023

Close #4

@mlocati mlocati mentioned this pull request Oct 29, 2023
Closed
@mlocati mlocati merged commit f96514e into main Oct 29, 2023
6 checks passed
@mlocati mlocati deleted the push-built-assets branch October 29, 2023 16:41
@szepeviktor
Copy link
Contributor

This PR shows that this project does not include viktor resources.
I have 3-4 thoughts.
But I am not onboard!

@mlocati
Copy link
Owner Author

mlocati commented Oct 29, 2023

this project does not include viktor resources.

I'm sorry I don't understand... what are those "viktor resources"?

@szepeviktor
Copy link
Contributor

szepeviktor commented Oct 29, 2023 •
edited
Loading

Viktor exercises Total Control©️ over every byte. So I spend countless hours cleaning up each byte.

  1. The source of build is the Internet, so we need a human/machine to check that the changes are okay.
  2. UNICODE changes are very-very-very rare So I would have viktor look at each change set.
  3. It should be a separate workflow
  4. Make it a PR (gh pr create) so other workflows will check it.
  5. if: is too long
  6. Never have a robot commit in the name of Michele! (set up a 🤖 unipoint-bot)

You can see that all these take viktor-resources.

mlocati added a commit that referenced this pull request Oct 29, 2023
@mlocati
Revert "Push changed built assets (#21)"
849726a 
This reverts commit f96514e.
@mlocati
Copy link
Owner Author

mlocati commented Oct 29, 2023

Yep, I agree. See #25

mlocati added a commit that referenced this pull request Oct 29, 2023
@mlocati @szepeviktor
Don't accept changes not made by humans (#25)
6f1f9ca 
* Revert "Push changed built assets (#21)"

This reverts commit f96514e.

* Don't accept changes not made by humans

* Super fancy error message if assets must be built

---------

Co-authored-by: Viktor Szépe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let tests.yml push back to the repo on merges
2 participants
@mlocati @szepeviktor