Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old grading function implementations #747

Merged
merged 25 commits into from
Dec 18, 2024
Merged

remove old grading function implementations #747

merged 25 commits into from
Dec 18, 2024

Conversation

rogthefrog
Copy link
Contributor

No description provided.

@rogthefrog rogthefrog requested a review from a team as a code owner December 13, 2024 02:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@rogthefrog rogthefrog force-pushed the remove-even-more-0.5-code branch from 16030a8 to 337b9ac Compare December 13, 2024 04:06
@rogthefrog rogthefrog mentioned this pull request Dec 13, 2024
Open
bkorycki
bkorycki reviewed Dec 13, 2024
View reviewed changes
src/modelgauge/main.py Outdated Show resolved Hide resolved
plugins/mistral/tests/test_mistral_sut.py Outdated Show resolved Hide resolved
@rogthefrog rogthefrog force-pushed the remove-even-more-0.5-code branch from 18038db to b3fe386 Compare December 17, 2024 00:19
bkorycki
bkorycki approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@bkorycki bkorycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks

src/modelgauge/main.py Outdated Show resolved Hide resolved
This was referenced Dec 17, 2024
Merged
Merged
@rogthefrog rogthefrog changed the base branch from remove-0.5-code to main December 18, 2024 21:42
@rogthefrog rogthefrog merged commit 803bc9f into main Dec 18, 2024
4 checks passed
@rogthefrog rogthefrog deleted the remove-even-more-0.5-code branch December 18, 2024 23:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkorycki bkorycki bkorycki approved these changes

@wpietri wpietri Awaiting requested review from wpietri

@dhosterman dhosterman Awaiting requested review from dhosterman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rogthefrog @bkorycki