Remove 0.5 code #743
Merged
Remove 0.5 code #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
bkorycki
had a problem deploying
to
Scheduled Testing
GitHub Actions
Error
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
Open
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
rogthefrog
approved these changes
Dec 16, 2024
| @@ -5,9 +5,9 @@ | |||
| import pytest | |||
|
|
|||
| from modelbench.benchmarks import BenchmarkScore, GeneralPurposeAiChatBenchmarkV1, Locale | |||
| from modelbench.hazards import HazardScore, SafeCaeHazard, SafeCbrHazard, SafeHatHazard, Standards | |||
| from modelbench.hazards import HazardScore, SafeHazardV1, Standards | |||
There was a problem hiding this comment.
Do you know the original motivation for having one individual subclass for each hazard?
Merged
* SUT arg(s) is now required by CLI * Get rid of DEFFAULT_SUTS * mb tests use centralized SUT fixtures * mv conftest up to root tests dir * Modelbench does not register SUTs * print known SUT uids on newlines * Remove SUT wrapper (#758)
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge PR #747 before this one.
Notes:
Record is now dumped in
run/recordsinstead ofweb. This might require a corresponding change in modellab.The CLI now prints out a table summary in place of a static site. Let me know if it is missing any useful benchmark data.
We should consider what we want to do about static content. If we want to keep it here, we will need to add tests to make sure that static content for the relevant objects expected my modellab indeed exists. This would avoid the numerous issues we've run into in the past w.r.t. uid changes not syncing up with the content.