Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user signup flow #757

Merged
merged 2 commits into from
Sep 12, 2023
Merged

feat: add user signup flow #757

merged 2 commits into from
Sep 12, 2023

Conversation

anhappdev
Copy link
Collaborator

@anhappdev anhappdev commented Jul 28, 2023

Part of #670

A user can either sign in anonymously or with email/password.
On the sign in with email/password screen, a user can also register for a new account.

To convert from an anonymous account to a registered account with email/password:

  1. Tap on the User Profile button
  1. Tap on the Email icon to enter an email and password

@github-actions
Copy link

github-actions bot commented Jul 28, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anhappdev
Copy link
Collaborator Author

I am using firebase_ui_auth which provides premade screens for user sign in and sign up flow. But this plugin does not support the Windows platform officially. I don't have experience with Windows or a Windows machine to test. So I am thinking either someone with Windows experience can jump in or maybe we can drop support for Windows (for now)?

@freedomtan
Copy link
Contributor

@mohitmundhragithub to help with the Windows part

@freedomtan
Copy link
Contributor

Currently there is no 3rd party authentication. We can add it later (in another PR)

@anhappdev
Copy link
Collaborator Author

anhappdev commented Aug 15, 2023

I removed the Firebase SDK from the Windows platform. For now, Firebase will only be supported on iOS and Android.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anhappdev anhappdev marked this pull request as ready for review August 15, 2023 12:04
@anhappdev anhappdev requested a review from a team as a code owner August 15, 2023 12:04
@anhappdev anhappdev requested a review from RSMNYS August 15, 2023 12:05
@anhappdev
Copy link
Collaborator Author

@freedomtan Did you have the time to review this PR? This one currently blocks some other issues.

@anhappdev anhappdev merged commit 84df717 into master Sep 12, 2023
@anhappdev anhappdev deleted the 670/user-signup branch September 12, 2023 03:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
@freedomtan
Copy link
Contributor

@anhappdev I cannot find the sign-in related menu items when I built from 84df717

@anhappdev
Copy link
Collaborator Author

@freedomtan If you build the app yourself, you need to follow this guide
https://github.com/mlcommons/mobile_app_open/blob/master/docs/environment-setup/env-setup-firebase.md
and set the vars in firebase_options.env. Else all Firebase related features will be hidden / disabled.

Or you can test the APK built by the CI, which has Firebase enabled.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants