Remove Firebase SDK from Windows platform

mlcommons · Aug 15, 2023 · 395c5e8 · 395c5e8
1 parent 459846e
commit 395c5e8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/flutter/windows/flutter/generated_plugin_registrant.cc b/flutter/windows/flutter/generated_plugin_registrant.cc
@@ -6,17 +6,11 @@
 
 #include "generated_plugin_registrant.h"
 
-#include <desktop_webview_auth/desktop_webview_auth_plugin.h>
-#include <firebase_core/firebase_core_plugin_c_api.h>
 #include <permission_handler_windows/permission_handler_windows_plugin.h>
 #include <share_plus/share_plus_windows_plugin_c_api.h>
 #include <url_launcher_windows/url_launcher_windows.h>
 
 void RegisterPlugins(flutter::PluginRegistry* registry) {
-  DesktopWebviewAuthPluginRegisterWithRegistrar(
-      registry->GetRegistrarForPlugin("DesktopWebviewAuthPlugin"));
-  FirebaseCorePluginCApiRegisterWithRegistrar(
-      registry->GetRegistrarForPlugin("FirebaseCorePluginCApi"));
   PermissionHandlerWindowsPluginRegisterWithRegistrar(
       registry->GetRegistrarForPlugin("PermissionHandlerWindowsPlugin"));
   SharePlusWindowsPluginCApiRegisterWithRegistrar(

diff --git a/flutter/windows/flutter/generated_plugins.cmake b/flutter/windows/flutter/generated_plugins.cmake
@@ -3,8 +3,6 @@
 #
 
 list(APPEND FLUTTER_PLUGIN_LIST
-  desktop_webview_auth
-  firebase_core
   permission_handler_windows
   share_plus
   url_launcher_windows

diff --git a/flutter/windows/windows-docker.mk b/flutter/windows/windows-docker.mk
@@ -44,6 +44,9 @@ flutter/windows/ci:
 		BAZEL_OUTPUT_ROOT_ARG=--output_user_root=C:/bazel-root/ \
 		BAZEL_LINKS_PREFIX=C:/bazel-links/ \
 		flutter/prepare \
+		# a work-around to have `pub get` not adding new plugins in CI env.
+		git restore flutter/windows/flutter/generated_plugin_registrant.cc \
+		git restore flutter/windows/flutter/generated_plugins.cmake \
 		flutter/windows/libs
 	cd ${fwc_local_project} && make \
 		flutter/test/integration