-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
19 feature create popovertsx component #76
Open
cywlol
wants to merge
5
commits into
dev
Choose a base branch
from
19-feature-create-popovertsx-component
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−1
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
db60117
added popover component
cywlol fcd95e5
added popover component
cywlol 9f532a7
remove text
cywlol e52eee6
ref update Merge branch 'dev' of https://github.com/mlatsjsu/mlatsjsu…
cywlol 5d3b3c5
changed section tag to btn
cywlol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
'use client'; | ||
import { cn } from '@/lib/cn'; | ||
import { Btn } from '@/components/atoms/btn'; | ||
import { useState, useEffect, useRef } from 'react'; | ||
|
||
interface Props extends React.HTMLProps<HTMLDivElement> { | ||
btn: React.ReactElement; | ||
children?: React.ReactNode; | ||
} | ||
|
||
export const Popover: React.FC<Props> = ({ | ||
btn, | ||
children, | ||
className, | ||
...props | ||
}) => { | ||
const [isVisible, setIsVisible] = useState(false); | ||
const buttonRef = useRef<HTMLButtonElement>(null); | ||
const contentRef = useRef<HTMLDivElement>(null); | ||
|
||
const toggleVisibility = () => { | ||
setIsVisible(!isVisible); | ||
}; | ||
|
||
useEffect(() => { | ||
const handleOutsideClick = (event: MouseEvent) => { | ||
if ( | ||
contentRef.current && | ||
!contentRef.current.contains(event.target as Node) && | ||
buttonRef.current && | ||
!buttonRef.current.contains(event.target as Node) | ||
) { | ||
setIsVisible(false); | ||
} | ||
}; | ||
|
||
document.addEventListener('mousedown', handleOutsideClick); | ||
return () => { | ||
document.removeEventListener('mousedown', handleOutsideClick); | ||
}; | ||
}, []); | ||
|
||
return ( | ||
<div className={cn('flex flex-col items-center gap-sm')}> | ||
<section ref={buttonRef} onClick={toggleVisibility}> | ||
{btn} | ||
</section> | ||
|
||
{isVisible && ( | ||
<div | ||
{...props} | ||
className={cn( | ||
'flex items-center rounded-md !border-line-width border-dashed border-light-neutral-gray bg-light-background p-lg text-light-primary', | ||
className, | ||
)} | ||
ref={contentRef} | ||
> | ||
{children} | ||
</div> | ||
)} | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
export { Popover as default } from './component'; | ||
export * from './component'; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Btn component instead of section tag. I don't think it's necessary to pass in a btn. You can add a 'text' prop for the btn text