Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19 feature create popovertsx component #76

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

cywlol
Copy link
Collaborator

@cywlol cywlol commented Nov 16, 2024

Resolve #19

@cywlol cywlol added the feature New feature or request label Nov 16, 2024
@cywlol cywlol requested a review from ahmadgaz November 16, 2024 02:17
@cywlol cywlol linked an issue Nov 16, 2024 that may be closed by this pull request
Comment on lines 45 to 47
<section ref={buttonRef} onClick={toggleVisibility}>
{btn}
</section>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Btn component instead of section tag. I don't think it's necessary to pass in a btn. You can add a 'text' prop for the btn text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Create popover.tsx component
2 participants