Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Dask client shutdown error #869

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Catch Dask client shutdown error #869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/fondant/component/component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"""This module defines interfaces which components should implement to be executed by fondant."""
import logging
import os
import typing as t
from abc import abstractmethod
Expand Down Expand Up @@ -57,7 +58,12 @@ def setup(self) -> t.Any:
return Client(cluster)

def teardown(self, client: t.Any) -> None:
return client.shutdown()
try:
client.shutdown()
except Exception:
msg = "Caught error while shutting down Client. Exiting anyway."
logging.exception(msg)
pass


class DaskLoadComponent(DaskComponent):
Expand Down
Loading